Bug 551746 - Problems with new version of Eclipse
Summary: Problems with new version of Eclipse
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 4.13   Edit
Hardware: PC Windows 10
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-03 12:20 EDT by Miles Johnson CLA
Modified: 2019-10-04 14:36 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Miles Johnson CLA 2019-10-03 12:20:37 EDT
I have just installed a new version of Eclipse (2019-09, coming from Photon) and I've ran into several issues.  I have tried to search for answers/fixes for these online, but have been unable to find anything in relation to the problems I'm seeing.

The first is that the brackets indicating a file has modifications compared to the git version (indicated by a greater than symbol >) are completely inaccurate.  Unless the meaning for this symbol has changed, it does not correctly reflect the git modification status as it did in Photon.

The second is that code completion no longer works correctly.  For instance, typing the period after matcher in String match = matcher.group(); shows completion such as .useAnchoringBounds(boolean).group() and others with 2 elements, but shows none with 1 element.

Thanks!

-- Configuration Details --
Product: Eclipse IDE 4.13.0.20190917-0000 (org.eclipse.epp.package.java.product)Installed Features:
 org.eclipse.platform 4.13.0.v20190916-1323
Comment 1 Thomas Wolf CLA 2019-10-03 14:28:16 EDT
The first is probably a combination of JGit using finer file timestamps and not knowing about the extra system git config of git-for-windows at %PROGRAMDATA%\Git\config.

The finer file timestamps can lead to JGit doing more file content checks than it did before, and if you have autocrlf set to true or input in that git-for-windows config only, it won't see it and wrongly conclude files were changed. Older JGit would not even do a content check since it compare file times only at millisecond precision, where they matched.

Using finer file timestamps can have a number of strange effects if timestamps between the file system and the git index don't have the same resolution. A fix for that is https://git.eclipse.org/r/#/c/149440/ , but that didn't make it into JGit 5.5.0 included in the Eclipse 2019-09 packages.

We'll release an EGit/JGit 5.5.1 very soon; that version will include that fix, which should resolve this problem.

You can also upgrade to EGit nightly (update site: https://download.eclipse.org/egit/updates-nightly ); it already has that fix.

If that doesn't help, try setting in the repository or user config core.autocrlf=true (or input, as appropriate for you).

EGit/JGit not knowing about the non-standard extra git config of git-for-windows is bug 535189, which is planned to be fixed in EGit 5.6.0.

I cannot comment on your second problem.
Comment 2 Thomas Wolf CLA 2019-10-04 02:12:38 EDT
(In reply to Thomas Wolf from comment #1)
> We'll release an EGit/JGit 5.5.1 very soon; that version will include that
> fix, which should resolve this problem.
EGit 5.5.1 is released now. Update site: https://download.eclipse.org/egit/updates .

> You can also upgrade to EGit nightly (update site:
> https://download.eclipse.org/egit/updates-nightly ); it already has that fix.
Comment 3 Miles Johnson CLA 2019-10-04 14:36:38 EDT
Thank you for your updates on this, I very much appreciate them.