Bug 551739 - P2Resolver.resolveDependencies(TargetPlatform, ReactorProject) should return a Map instead of a List
Summary: P2Resolver.resolveDependencies(TargetPlatform, ReactorProject) should return ...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Tycho (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 blocker (vote)
Target Milestone: ---   Edit
Assignee: Christoph Laeubrich CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 487341
  Show dependency tree
 
Reported: 2019-10-03 08:55 EDT by Christoph Laeubrich CLA
Modified: 2021-04-28 16:52 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Laeubrich CLA 2019-10-03 08:55:02 EDT 
org.eclipse.tycho.p2.resolver.facade.P2Resolver.resolveDependencies(TargetPlatform, ReactorProject) currently returns a List of P2ResolutionResults.
But the code using this part of the software requires a Mapping instead, currently this is done by assume that the list index of resolveDependencies is equal to the index of configuration.getEnvironments()

The code at that point already states that this has to be fixed and "is just wrong", this currently blocks Bug 487341
Comment 1 Eclipse Genie CLA 2019-10-03 09:16:33 EDT 
New Gerrit change created: https://git.eclipse.org/r/150542
Comment 2 Mickael Istria CLA 2019-10-07 04:26:41 EDT 
Thanks Christoph!