551589 – Add more widgets to WidgetFactories (like (C)Combo, Scale, Slider, Sash, Shell, ...)

Bug 551589 - Add more widgets to WidgetFactories (like (C)Combo, Scale, Slider, Sash, Shell, ...)

Summary: Add more widgets to WidgetFactories (like (C)Combo, Scale, Slider, Sash, Shel...

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.14
Hardware:	All All

Importance:	P3 enhancement (vote)
Target Milestone:	4.17 M3
Assignee:	Marcus Höpfner
QA Contact:

URL:
Whiteboard:
Keywords:	api, noteworthy

Depends on:
Blocks:	566162
	Show dependency tree

Reported:	2019-09-28 05:35 EDT by Marcus Höpfner
Modified:	2020-08-19 06:52 EDT (History)
CC List:	6 users (show)

See Also:	550254 Gerrit Change Gerrit Change Gerrit Change Gerrit Change Git Commit Git Commit Git Commit Git Commit Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Marcus Höpfner

2019-09-28 05:35:51 EDT

IMHO WidgetFactory should support a few more widgets.
It will be released soon as API (refer to https://bugs.eclipse.org/bugs/show_bug.cgi?id=550254) hence it should be able to create more widgets.

WDYT is missing for a standard usecase (whatever a standard use case :) is ).

Today there is:
- Button
- Label
- Text
- Composite
- Spinner
- Table 
- Tree

I tend to add Combo, CCombo, Sash and Shell.

Comment 1 Eclipse Genie

2019-09-29 13:17:21 EDT

New Gerrit change created: https://git.eclipse.org/r/150335

Comment 2 Eclipse Genie

2019-09-29 13:17:26 EDT

New Gerrit change created: https://git.eclipse.org/r/150334

Comment 3 Eclipse Genie

2019-09-29 13:17:40 EDT

New Gerrit change created: https://git.eclipse.org/r/150338

Comment 4 Eclipse Genie

2019-12-21 14:52:57 EST

New Gerrit change created: https://git.eclipse.org/r/154952

Comment 5 Mickael Istria

2020-02-10 04:32:17 EST

@Marcus: with the introduction of such factories, can you please try to find in the same repo for eah of them one example of a common UI that can leverage the factory?
Introducing new APIs without any use-case makes testing & review harder, and also misses to highlight the value proposal.

Comment 6 Eclipse Genie

2020-06-09 05:33:27 EDT

Gerrit change https://git.eclipse.org/r/150334 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a1a4de65fa44c09452b4f12d20abc85780b238eb

Comment 7 Eclipse Genie

2020-06-09 07:00:27 EDT

Gerrit change https://git.eclipse.org/r/150335 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2ecf7f617dfdcc1d41fa791b5ed7126bbd6d0b17

Comment 8 Eclipse Genie

2020-06-10 01:20:09 EDT

Gerrit change https://git.eclipse.org/r/150338 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=9795b919aa010346de944d816fabdab76dbf313a

Comment 9 Eclipse Genie

2020-06-22 07:46:13 EDT

Gerrit change https://git.eclipse.org/r/154952 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1a01cbd5e0b618de4b0338067504a0ce5c5d35ef

Comment 10 Matthias Becker

2020-06-22 07:49:23 EDT

Thank you for your contribution Marcus.

Comment 11 Eclipse Genie

2020-06-23 01:54:36 EDT

New Gerrit change created: https://git.eclipse.org/r/165332

Comment 12 Eclipse Genie

2020-06-23 02:57:29 EDT

Gerrit change https://git.eclipse.org/r/165332 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=4826c9a737f182e9baf802542876fe213bfb8a89

Comment 13 Lars Vogel

2020-08-03 08:17:31 EDT

Thank you for this development, I was about to open a similar bug for Combo and CCombo as I wanted to use this in a customer RCP project but I see that you did this already.

Please add to N&. Reopening for this purpose.

Comment 14 Lars Vogel

2020-08-18 11:19:10 EDT

Marcus, are you still around to create a N&N entry?

Comment 15 Lars Vogel

2020-08-18 11:33:48 EDT

Added a minimal entry.

Gerrit change https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/167906 was merged to [master].
Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=308fe32182cbfbc11b9308fd8a4a1e057f853b3f

Comment 16 Marcus Höpfner

2020-08-19 06:52:22 EDT

(In reply to Lars Vogel from comment #14)
> Marcus, are you still around to create a N&N entry?

Hi Lars, thanks for creating. At the moment I'm really busy with other things. Sorry