Community
Participate
Working Groups
Once Bug is fixed, we should fix our light and dark theme issues in this area.
Once Bug 549916 is fixed, we should fix our light and dark theme issues in this area.
New Gerrit change created: https://git.eclipse.org/r/150248
Created attachment 280071 [details] POM Editor in Dark Mode For dark mode, i use the new stylings now (see attachment). However, which issues are there in the light theme?
I think this bug is related to https://bugs.eclipse.org/bugs/show_bug.cgi?id=531532
(In reply to Eclipse Genie from comment #2) > New Gerrit change created: https://git.eclipse.org/r/150248 I just tested this with the plugin.xml editor. On the dependencies tab you still see that the colours of the "Automated Management of Dependencies" are not correct. Just hover over and expand and collapse.
I guess you mean that the hover color is too dark? In the new patch set I used a lighter color. But I do not use the dark theme myself neither I am familiar with the colors used in the themes so if you have any suggestions just feel free to mention them!
Created attachment 280121 [details] MANIFEST.MF Editor dark theme See screenshot above (Automated Management... label is with mouse hovering)
Created attachment 280124 [details] Screenshot Looks already way better. I suggest we use the same color in both places, the new one looks better to me that the blue one. I think this is the #cccccc; color code Can you update the change?
Gerrit change https://git.eclipse.org/r/150248 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a791ac13ea37bf38f6ab3904854e7c826f592480
Matthias, please reopen if your hover issue still exists, could not reproduce. Benedikt, thanks!
Created attachment 280138 [details] Hower issue Problem with hover still persists
It's still the same
Created attachment 280169 [details] Manifest Dark on Win/Linux (In reply to Matthias Becker from comment #12) > It's still the same You are using Linux, I assume? I cannot reproduce this on my machine, but I was wondering why the labels are slightly blue in your screen capture, on my (windows) machine they are just grey/white. Using the dark theme [linux] I get the same colors as in Lars' screenshot. Attached screenshots (left: windows dark theme, right: linux dark theme on windows) Don't know if this is intended but seems somewhat strange in my eyes...
Removed milestone as no one reacted to https://www.eclipse.org/lists/eclipse-dev/msg11217.html.
*** Bug 531532 has been marked as a duplicate of this bug. ***
I suggest to move the hover issue to a new bug and close this one. Please add to N&N.
Opened bug 552829 for the hovering issue. I mentioned it already in N&N for bug 549916, see https://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=fa40a43d480393c09f79a7654f4c44d77f18ecd4 Think that should be sufficient, what do you think, Lars?
(In reply to Benedikt Kuntz from comment #17) > Opened bug 552829 for the hovering issue. > > I mentioned it already in N&N for bug 549916, see > https://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/ > ?id=fa40a43d480393c09f79a7654f4c44d77f18ecd4 > Think that should be sufficient, what do you think, Lars? +1, sorry for asking for it again.
