Bug 551390 - Remove custom styling and drawing from PerspectiveSwitcher
Summary: Remove custom styling and drawing from PerspectiveSwitcher
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.13   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.14 M1   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
: 497476 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-09-23 18:25 EDT by Lars Vogel CLA
Modified: 2019-09-25 14:44 EDT (History)
4 users (show)

See Also:

Attachments
New (20.63 KB, image/png)
2019-09-23 18:25 EDT, Lars Vogel CLA 		no flags Details
Old (22.62 KB, image/png)
2019-09-23 18:25 EDT, Lars Vogel CLA 		no flags Details
The line in Eclipse 3.7 (2.49 KB, image/png)
2019-09-24 03:30 EDT, Paul Pazderski CLA 		no flags Details
Screenshot (27.74 KB, image/png)
2019-09-24 15:42 EDT, Lars Vogel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2019-09-23 18:25:07 EDT 
Created attachment 279994 [details]
New

I personally don't find the extra curve in the perspective switcher very appealing and suggest to remove it.
Comment 1 Lars Vogel CLA 2019-09-23 18:25:25 EDT 
Created attachment 279995 [details]
Old
Comment 2 Lars Vogel CLA 2019-09-23 18:26:44 EDT 
Matthias, Thomas, WDYT?
Comment 3 Eclipse Genie CLA 2019-09-23 18:27:15 EDT 
New Gerrit change created: https://git.eclipse.org/r/150028
Comment 4 Matthias Becker CLA 2019-09-24 02:33:07 EDT 
(In reply to Lars Vogel from comment #2)
> Matthias, Thomas, WDYT?

I am okay with this change.
Comment 5 Paul Pazderski CLA 2019-09-24 03:30:08 EDT 
Created attachment 279996 [details]
The line in Eclipse 3.7

+1. This line is broken anyway. On Windows it is white on light gray. I didn't even noticed it before this ticket.

For the 'broken' part: I still have an old Eclipse 3.7 installed from another bug. If you look at the screenshot the line was much nicer back then and served as drag point and separator. (which is now the vertical dotted line)
Comment 6 Lars Vogel CLA 2019-09-24 15:42:31 EDT 
Created attachment 280007 [details]
Screenshot

Thomas hinted in the Gerrit that we should remove the special styling for internal element PerspectiveSwitcher. After doing this change, I agree, the toolbar looks much more consistent. I will update the Gerrit soon with the change. It removes the CSS styling the option for it and the customer drawing.
Comment 7 Eclipse Genie CLA 2019-09-24 15:46:03 EDT 
New Gerrit change created: https://git.eclipse.org/r/150067
Comment 8 Lars Vogel CLA 2019-09-25 10:00:39 EDT 
*** Bug 497476 has been marked as a duplicate of this bug. ***
Comment 10 Eclipse Genie CLA 2019-09-25 14:02:48 EDT 
New Gerrit change created: https://git.eclipse.org/r/150145