Community
Participate
Working Groups
Similar to the perspectives, we should allow the user to hide the text of the Find Action toolbar contributionb
(In reply to Lars Vogel from comment #0) > Similar to the perspectives, we should allow the user to hide the text of > the Find Action toolbar contributionb Actually, it must not show the text by default - like the perspective icons. Currently this is the only icon with text and it looks ugly. But it should have a context menu called 'Show Text', so that people who prefer this, can enable it - like for the perspective icons. NOTE: This bug looks very similar to bug 551139. Maybe even a duplicate.
This really need to be fixed.
(In reply to Dani Megert from comment #2) > This really need to be fixed. What should be the default? Text shown or not shown?
(In reply to Lars Vogel from comment #3) > (In reply to Dani Megert from comment #2) > > This really need to be fixed. > > What should be the default? Text shown or not shown? Not shown as this would be the ONLY text shown in the toolbar (as it is right now).
New Gerrit change created: https://git.eclipse.org/r/151691
Patch is ready and will hide the text by default. I did not implement the ability to remove this toolitem via the context menu as the other toolitems also do not provide this option. I even think the ability to show the text is overdesign but I guess we have to keep this option as some users may feel strong about removing it completely. I plan to merge the Gerrit once the verification build is done.
Gerrit change https://git.eclipse.org/r/151691 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a73a41fb2cf459af86d008bd016a890a756343a3
(In reply to Eclipse Genie from comment #7) > Gerrit change https://git.eclipse.org/r/151691 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a73a41fb2cf459af86d008bd016a890a756343a3 > Thanks Lars. Unfortunately it introduces a critical regression: 1. Choose to show text ==> works 2. Restart ==> NPE and magnifier button/icon is not shown. Clicking on the text does nothing and the menu to hide the text does not work either. ==> Find Actions functionality via mouse is forever lost for that workspace. Workaround is to use Ctrl+3. There's also a minor issue: it looks like there's a separator above 'Show Text' in the menu.
(In reply to Dani Megert from comment #8) > (In reply to Eclipse Genie from comment #7) > > Gerrit change https://git.eclipse.org/r/151691 was merged to [master]. > > Commit: > > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a73a41fb2cf459af86d008bd016a890a756343a3 > > > Thanks Lars. Unfortunately it introduces a critical regression: > 1. Choose to show text ==> works > 2. Restart > ==> NPE and magnifier button/icon is not shown. Clicking on the text does > nothing and the menu to hide the text does not work either. > ==> Find Actions functionality via mouse is forever lost for that workspace. > Workaround is to use Ctrl+3. > > > There's also a minor issue: it looks like there's a separator above 'Show > Text' in the menu. Fixed with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=247232a7e9665b7b3254fa6476989081557c2198
Thanks, Dani for fixing this.
(In reply to Dani Megert from comment #9) > Fixed with > https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=247232a7e9665b7b3254fa6476989081557c2198 > Verified in eclipse-SDK-I20191117-1800-win32-x86_64. Note that this only fixed the NPE. The unwanted separator is covered by bug 553172.
This fix has removed the ability to hide the "Find Actions" item completely. That is okay. However, that refactoring might be incomplete, since bug 537131 added a global preference to hide the former quick access. I do have that preference enabled in my personal oomph setup, and it seems not to affect the visibility of "Find Actions" in a freshly installed I build. Nevertheless we may want to revert the changes of bug 537131 to be on the safe side.
(In reply to Michael Keppler from comment #12) > This fix has removed the ability to hide the "Find Actions" item completely. > That is okay. However, that refactoring might be incomplete, since bug > 537131 added a global preference to hide the former quick access. > > I do have that preference enabled in my personal oomph setup, and it seems > not to affect the visibility of "Find Actions" in a freshly installed I > build. Nevertheless we may want to revert the changes of bug 537131 to be on > the safe side. Please file a new bug report.
