Community
Participate
Working Groups
Having to instantiate a new DisplayHelper everytime generates a lot of noise. To ease usage, DisplayHelper should provide a static DisplayHelper.waitForCondition(condition, display, timeout)
New Gerrit change created: https://git.eclipse.org/r/149787
Gerrit change https://git.eclipse.org/r/149787 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=67509b607ce08ed7f45ef3997508f9c9869cfca6
Added to N&N https://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=d560a2ffbe2bc0fd92175ae38c4f3e6fc0c5adc8
New Gerrit change created: https://git.eclipse.org/r/149856
Gerrit change https://git.eclipse.org/r/149856 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ef6b81ec1107f20af52375ebd6047400a0e82b81
I'm going to revert the change I made for this one and adapt a few things, as Jens improvements in bug 412569 (with DisplayHelper.create(BooleanSupplier) do cover the case already perfectly, so no need to add new APIs for that. Too bad I didn't notice the new change earlier!
New Gerrit change created: https://git.eclipse.org/r/149870
Gerrit change https://git.eclipse.org/r/149870 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=4bc601b3bba0c97506362843fd362654b7d1ede2
Thanks Jens!
@Mickael, I don't find where to push a patch for N&N but I think there is a type in this source code: ``` assertTrue(DisplayHelper.waitForCondition()display, 1000, () -> some.boolean() && expression)) ``` IIRC it should be: ``` assertTrue(DisplayHelper.waitForCondition(display, 1000, () -> some.boolean() && expression)) ``` Check the extra ) in your version between `waitForCondition` and `display`.
(In reply to Gautier de SAINT MARTIN LACAZE from comment #10) > I don't find where to push a patch for N&N https://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/
Maybe I'm not totally wake up, I can't push to gerrit... "Can't connect to any repository: https://git.eclipse.org/r/www.eclipse.org/eclipse/news (https://git.eclipse.org/r/www.eclipse.org/eclipse/news: not authorized)"
You're using anonymous http, try using ssh remote URI instead.
Is N&N really for news about tools that are used internally by the platform development team, such as DisplayHelper? I think N&N is for news about the tools and software that the platform *provides*, not things that are use to develop the platform.
(In reply to Jens Lideström from comment #14) > Is N&N really for news about tools that are used internally by the platform > development team, such as DisplayHelper? > I think N&N is for news about the tools and software that the platform > *provides*, not things that are use to develop the platform. Although it's not officually an API, the test harness bundle and DisplyHelper are very wodely used.by other projects, and this improvements can be profitable beyond Platform. It's IMO worth the note.
(In reply to Mickael Istria from comment #15) > the test harness bundle and > DisplyHelper are very wodely used.by other projects All right. Had I known that DisplyHelper is used by other projects I would have though twice before adding new methods to it! But I think the additions are okay anyway.
New Gerrit change created: https://git.eclipse.org/r/151253
Gerrit change https://git.eclipse.org/r/151253 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=7198e1e679ecd26e9859bc58f83218ed7b61e02c
