Comment 1 Eclipse Genie 2019-09-16 14:38:41 EDT

New Gerrit change created: https://git.eclipse.org/r/149605

Comment 2 Eclipse Genie 2019-09-24 15:21:38 EDT

Gerrit change https://git.eclipse.org/r/149605 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=de022badeada826e35e21a8908f9ba659bee6da2

Comment 3 Phil Beauvoir 2020-07-05 10:56:13 EDT

This change has broken the use of DrillDownAdapter in our app, Archi.

Calling DrillDownAdapter#goHome() on a TreeViewer does not return to the root node but only the previous node on the stack.

Comment 4 Phil Beauvoir 2020-07-05 11:21:34 EDT

It seems that each DrillFrame is being pushed onto the Deque stack in the wrong order.

If we have a tree:

Root
  |---Node 1
       |---Node 2

When DrillDownAdapter#goInto() is called on Node 1 and then Node 2 the Deque stack contains DrillFrames in this order:

[0] Node 1
[1] Root

Calling DrillDownAdapter#goHome() calls DrillStack#goHome() which calls Deque#getFirst() which returns element [0] and this is wrong.

Comment 5 Phil Beauvoir 2020-07-05 11:28:37 EDT

So I'm wondering if in DrillStack instead of this:


public DrillFrame goHome() {
   DrillFrame aFrame = fStack.getFirst();
   reset();
   return aFrame;
}


It should be this?

public DrillFrame goHome() {
   DrillFrame aFrame = fStack.getLast();
   reset();
   return aFrame;
}

Comment 6 Phil Beauvoir 2020-07-05 11:41:21 EDT

Indeed it is the case as per my previous comment. 

I changed 

DrillFrame aFrame = fStack.getFirst();

to:

DrillFrame aFrame = fStack.getLast();

And goHome() works as expected.

Comment 7 Lars Vogel 2020-07-05 12:59:47 EDT

(In reply to Phil Beauvoir from comment #6)
> Indeed it is the case as per my previous comment. 
> 
> I changed 
> 
> DrillFrame aFrame = fStack.getFirst();
> 
> to:
> 
> DrillFrame aFrame = fStack.getLast();
> 
> And goHome() works as expected.

Phil, can you open a new bug and push a Gerrit?

Comment 8 Phil Beauvoir 2020-07-05 13:10:31 EDT

(In reply to Lars Vogel from comment #7)
> Phil, can you open a new bug and push a Gerrit?

Opened Bug #564941