Community
Participate
Working Groups
Created attachment 279807 [details] Screenshot Our toolbar looks very "spacy" to me, we have lots of empty space about and below the icons. Is this a Linux issue or is this present in all platforms?
Matthias, does it also waste so much space on the Mac?
Created attachment 279810 [details] Toolbar on macOS (In reply to Lars Vogel from comment #1) > Matthias, does it also waste so much space on the Mac? See yourself.
Looks similar to Mac, IMO. What does it looks like on Windows?
Created attachment 279813 [details] Toolbar on Windows 7
Ok, my first guess would be that our drag handler icons are too high. I will now apply my non-existing drawing skills to modify them and see if they are responsible for the spacing.
Created attachment 279814 [details] Dragging Toolbar elements on Windows 7 I think it is only the drag handler icon from perspective part. See attached screenshot where I dragged two different groups.
Second guess: ToolBarManagerRenderer#createWidget line 441 calling into CSSRenderingUtils#frameMeIfPossible
(In reply to Lars Vogel from comment #7) > Second guess: ToolBarManagerRenderer#createWidget line 441 calling into > CSSRenderingUtils#frameMeIfPossible ImageBasedFrame returns with a size of 31px in line 111 in CSSRenderingUtils#frameMeIfPossible even though I pass in a 16px icon.
Created attachment 279815 [details] Screenshot of with an without perspective switcher Looks like perspective switcher is the evil guy.
New Gerrit change created: https://git.eclipse.org/r/149187
Matthias and Paul, please test on Mac and Windows. Btw. I notice our waste of space because in the last Hamburg hackathon someone was using Eclipse and IntelliJ side by side on a very small display and we did not look very good.
Created attachment 279816 [details] Screenshot - Light side by side
Created attachment 279817 [details] Screenshot stacked on each other
Created attachment 279818 [details] Toolbar after change on Windows 10
(In reply to Paul Pazderski from comment #14) > Created attachment 279818 [details] > Toolbar after change on Windows 10 Hard for me to see a difference. Is it smaller?
Maybe a pixel smaller. But imo it was already smaller than the old linux version.
Thanks, Paul. Will soon install Windows on one of my machines and I should therefore soon be able to investigate.
(In reply to Lars Vogel from comment #15) > (In reply to Paul Pazderski from comment #14) > > Created attachment 279818 [details] > > Toolbar after change on Windows 10 > > Hard for me to see a difference. Is it smaller? Some on Mac. I don't see a difference in the height of the toolbar on mac. But only see some pixel differences on the perspective switcher - but just different not better nor worse
Created attachment 279820 [details] Layoutspy Matthias and Paul, can you fire up "Layout Spy" via Ctrl+3 and use "Select Control" to see who is the evil guy? Screenshot of Layout Spy attached.
Created attachment 279821 [details] Both versions over each other. (In reply to Matthias Becker from comment #18) > Some on Mac. I don't see a difference in the height of the toolbar on mac. > But only see some pixel differences on the perspective switcher - but just > different not better nor worse Both versions over each other. The top one has 50% opacity. You see that the perspective switcher is "blurry" because the position is not the same. The rest of the toolbar ist pixel-perfect identical.
Created attachment 279822 [details] Layout Spy 1
Created attachment 279823 [details] Layout Spy 2
Created attachment 279824 [details] Layout Spy 3
Created attachment 279825 [details] Layout spy Windows 7
As the current patch IMHO significantly improves the UX on Linux I plan to merge it unless someone is against it. We can improve the other OSs with separate Gerrits.
I agree on Linux but in my opinion the other OS are already good and reducing the gabs would make the toolbar look crowded.
Gerrit change https://git.eclipse.org/r/149187 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=7b5a1eb51b1182b3576cde64a2a816a8e9cbfdcd
Fix seems to influence only Linux, so marking as fixed.
