Bug 550832 - Remove gif which we left during the move to png files
Summary: Remove gif which we left during the move to png files
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 4.13   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.17 M1   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-06 05:10 EDT by Lars Vogel CLA
Modified: 2021-07-12 12:18 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2019-09-06 05:10:11 EDT
During the transition from gifs to png we left a view gifs as the opened views would persists them. I suggest to remove them now, its been a few years and continuing to carry this "garbage" is not good for our users in general as they unnecessary increase download size.
Comment 1 Lars Vogel CLA 2019-09-06 05:10:36 EDT
Matthias, what you you think?
Comment 2 Lars Vogel CLA 2019-09-06 05:18:17 EDT
Also, I think we can clean the eclipse.platform.image master from gifs.
Comment 3 Matthias Becker CLA 2019-09-06 08:38:51 EDT
(In reply to Lars Vogel from comment #2)
> Also, I think we can clean the eclipse.platform.image master from gifs.

I already did this. See https://git.eclipse.org/r/#/c/145105/
Comment 4 Lars Vogel CLA 2019-09-06 10:18:33 EDT
No objections for the normal repo?
Comment 5 Matthias Becker CLA 2019-09-06 10:45:10 EDT
(In reply to Lars Vogel from comment #4)
> No objections for the normal repo?

I am not sure about this. Is the persisteted path to the GIFs (I think in workbench.xmi) updated once you open that view? If this is the case we can assume that all (most) users have opened these views in old workspaces. If not then these path remain as long as the workspace lives.
Comment 6 Lars Vogel CLA 2019-09-11 08:21:29 EDT
(In reply to Matthias Becker from comment #5)
> (In reply to Lars Vogel from comment #4)
> > No objections for the normal repo?
> 
> I am not sure about this. Is the persisteted path to the GIFs (I think in
> workbench.xmi) updated once you open that view? If this is the case we can
> assume that all (most) users have opened these views in old workspaces. If
> not then these path remain as long as the workspace lives.

The can simply close the view and open it again. We can add a section to the N&N so that it is easier to find for the user.
Comment 7 Eclipse Genie CLA 2019-09-12 09:06:18 EDT
New Gerrit change created: https://git.eclipse.org/r/149411
Comment 8 Lars Vogel CLA 2019-09-13 22:54:26 EDT
I postphone this for another release.
Comment 9 Lars Vogel CLA 2020-05-22 09:45:43 EDT
Plan to do this early 4.17
Comment 10 Eclipse Genie CLA 2020-05-22 09:48:30 EDT
New Gerrit change created: https://git.eclipse.org/r/163429
Comment 11 Eclipse Genie CLA 2020-05-22 09:51:41 EDT
New Gerrit change created: https://git.eclipse.org/r/163430
Comment 15 Eclipse Genie CLA 2020-06-12 02:18:47 EDT
New Gerrit change created: https://git.eclipse.org/r/164756
Comment 16 Eclipse Genie CLA 2020-06-12 02:38:19 EDT
New Gerrit change created: https://git.eclipse.org/r/164759
Comment 17 Eclipse Genie CLA 2020-06-12 02:39:30 EDT
New Gerrit change created: https://git.eclipse.org/r/164760
Comment 18 Eclipse Genie CLA 2020-06-12 02:42:06 EDT
New Gerrit change created: https://git.eclipse.org/r/164762
Comment 19 Eclipse Genie CLA 2020-06-12 02:42:07 EDT
New Gerrit change created: https://git.eclipse.org/r/164763
Comment 20 Eclipse Genie CLA 2020-06-12 02:42:18 EDT
New Gerrit change created: https://git.eclipse.org/r/164764
Comment 21 Eclipse Genie CLA 2020-06-12 02:45:30 EDT
New Gerrit change created: https://git.eclipse.org/r/164765
Comment 22 Eclipse Genie CLA 2020-06-12 02:47:42 EDT
New Gerrit change created: https://git.eclipse.org/r/164766
Comment 23 Eclipse Genie CLA 2020-06-12 02:47:53 EDT
New Gerrit change created: https://git.eclipse.org/r/164768
Comment 24 Eclipse Genie CLA 2020-06-12 02:51:15 EDT
New Gerrit change created: https://git.eclipse.org/r/164769
Comment 25 Eclipse Genie CLA 2020-06-12 02:53:27 EDT
New Gerrit change created: https://git.eclipse.org/r/164770
Comment 27 Eclipse Genie CLA 2020-06-12 02:58:00 EDT
New Gerrit change created: https://git.eclipse.org/r/164772
Comment 28 Eclipse Genie CLA 2020-06-12 02:58:12 EDT
New Gerrit change created: https://git.eclipse.org/r/164773
Comment 29 Eclipse Genie CLA 2020-06-12 02:59:23 EDT
New Gerrit change created: https://git.eclipse.org/r/164774
Comment 43 Lars Vogel CLA 2020-06-17 11:02:07 EDT
I think we are done here.
Comment 44 Andrey Loskutov CLA 2021-07-12 12:18:33 EDT
(In reply to Lars Vogel from comment #43)
> I think we are done here.

This caused a regression, see bug 574805. "Workaround" from comment 6 isn't working, the same broken icon is shown after restart.