Community
Participate
Working Groups
I've got the (very cool) "show key bindings when command is invoked" turned on, using Eclipse SDK I20190904-0605. If I hit `Alt+Shift+Q Q` to get the "Show view" dialog, then the popup only show "Q - show view". The first part of the sequence is missing.
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
This is still an issue.
This seems to be an issue that we have two "normal" characters here ("Q"). Other shortcuts that include 4 keypresses with 3 modifiers but only one normal character like the "Quick Search..." ("Option, Shift, Command, L" on macOS) are displayed correctly. The same issue exists for Run As > JUnit Test ("Option, Command, X, T"). The problem seems to be be in the command framework because the ShowKeysListener (that is registered to show the key-binding) is not called only after the second "Q" is triggered.
(In reply to Matthias Becker from comment #3) > This seems to be an issue that we have two "normal" characters here ("Q"). > Other shortcuts that include 4 keypresses with 3 modifiers but only one > normal character like the "Quick Search..." ("Option, Shift, Command, L" on > macOS) are displayed correctly. I'm under the impression that it's not about character or not character, but more about the popup showing only the last key event of the binding sequence. Eg if shortcut would be "F1 F2" as a sequenxe (not "F1+F2" as a single keystroke combination) popup would show only F2 as the last hit of the sequence. > The problem seems to be be in the command framework because the > ShowKeysListener (that is registered to show the key-binding) is not called > only after the second "Q" is triggered. I think the problem is that the popup just shows the event that completed the sequence and doesn't show the whole KeyBinding. The command framework has API to retrieve thw whole keybonding for a sequence, the popup may not use them well.
(In reply to Mickael Istria from comment #4) > The command framework has API to retrieve thw whole keybonding for a sequence, > the popup may not use them well. Can you tell me that API?
(In reply to Matthias Becker from comment #5) > Can you tell me that API? IBindingServer.getBindingsFor(command)
One good example here is the Show View command (Window > Show View... > Others...); with keybinding popup on: * Trigger it with mouse: popup says Alt+Shift+Q Q * Trigger it with Alt+Shift+Q Q shortcut: popup says just Q
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/187739
(In reply to Eclipse Genie from comment #8) > New Gerrit change created: > https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/187739 Thanks for taking care.
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/187739 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2e53276af16b9198dfe066117ec551a735c0a50d
