Bug 550501 - [GTK] Ability to place not digit characters to DateTime
Summary: [GTK] Ability to place not digit characters to DateTime
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.12   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.14 M1   Edit
Assignee: Eric Williams CLA
QA Contact:
URL:
Whiteboard: RHT
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2019-08-28 01:52 EDT by Ilnur Zalyaev CLA
Modified: 2019-10-08 13:27 EDT (History)
2 users (show)

See Also:

Attachments
problem repsresenting video (134.24 KB, video/mp4)
2019-08-28 01:54 EDT, Ilnur Zalyaev CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilnur Zalyaev CLA 2019-08-28 01:52:59 EDT 
Debian Stretch
GTK 3.22.30
Eclipse SDK 4.12M3.

I think, that it is a bug, when user able to place some not digit characters to DateTime widget.
And if it is a feature, when i should say, that where is another bug: when i place some cyrillyc characters it writes some arabic characters instead.
Comment 1 Ilnur Zalyaev CLA 2019-08-28 01:54:04 EDT 
Created attachment 279697 [details]
problem repsresenting video
Comment 2 Ilnur Zalyaev CLA 2019-09-12 11:03:56 EDT 
My solution of wrong chars is modification of DateTime.keyToString(int) method.
I replaced string:
    return (char)key;
by:
    return (char)GDK.gdk_keyval_to_unicode(key);
Comment 3 Eric Williams CLA 2019-09-12 11:08:12 EDT 
Thanks for the bug report, can you attach the snippet you used to reproduce the issue?
Comment 4 Eclipse Genie CLA 2019-09-17 15:07:50 EDT 
New Gerrit change created: https://git.eclipse.org/r/149685
Comment 6 Eric Williams CLA 2019-09-17 15:48:50 EDT 
(In reply to Eclipse Genie from comment #5)
> Gerrit change https://git.eclipse.org/r/149685 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=57b4cf729c3a96fb4394e008b37f66b7c65e2946

In master now.
Comment 7 Eric Williams CLA 2019-10-08 13:27:18 EDT 
Verified in I20191008-0600.