Bug 550153 - Don't hide breakpoint icons behind light bulb icons
Summary: Don't hide breakpoint icons behind light bulb icons
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.12   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.13 RC1   Edit
Assignee: Paul Pazderski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-16 09:44 EDT by Taro Kyo CLA
Modified: 2020-05-23 16:44 EDT (History)
5 users (show)

See Also:


Attachments
Breakpoint over info/warning bulb (3.03 KB, image/png)
2019-08-16 10:02 EDT, Paul Pazderski CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Taro Kyo CLA 2019-08-16 09:44:56 EDT
When I'm toggling breakpoints, usually it's easy to see where the breakpoint was set with an icon indicator, as well as being able to see the breakpoint appearing in the list of Breakpoints.

This issue is mainly focusing on the icons in the sidebar, on the left side of the codes in the editor.

When you have a light bulb displayed, you cannot see anything that's behind the light bulb icons. You cannot see breakpoints. You cannot see other icons that's not light bulbs.

I request that there should be a better display for the light bulbs. I understand the light bulbs are there to notify the users that there is something that needs to be alerted, and it is important to handle these cases for the users. But, it would also be nice if the light bulbs icon are smaller than default icons, so that the users can still see what was set on that particular line while also knowing that line of code needs attention.

A smaller icon for the light bulbs is all I wanted, so the breakpoints icon can be shown instead of getting hidden by the light bulbs.


-- Configuration Details --
Product: Eclipse IDE 4.12.0.20190614-1200 (org.eclipse.epp.package.jee.product)Installed Features:
 org.eclipse.platform 4.12.0.v20190605-1801
Comment 1 Paul Pazderski CLA 2019-08-16 10:02:04 EDT
Created attachment 279606 [details]
Breakpoint over info/warning bulb

If the icons wouldn't be so small I had suggested to halve there size and show 4 in a grid in case there is more than one annotation at the same line.

But it seems there exist some kind of prioritization between annotations (see screenshot) and it would be useful to show breakpoint over warning bulb (but under error bulb).

I think same is a good idea for TODO annotation and maybe some more since breakpoint is a quite small icon. (I remember vague there was a recent ticket for the todo case)
Comment 2 Sarika Sinha CLA 2019-08-19 00:21:57 EDT
This can be controlled by Preferences->General->Editors->Text Editors->Annotations

I generally remove the warning from vertical ruler.
Problem is for any annotations, if they exist on the same line.
Comment 3 Paul Pazderski CLA 2019-08-22 17:59:17 EDT
So I took some time to learn more how annotations work and found the presentation layer. Then I tested which layer is might be appropriate. All that to find some other bug where this problem was discussed years ago and almost solved... (bug 80089 comment 28)
Comment 4 Eclipse Genie CLA 2019-08-22 18:00:07 EDT
New Gerrit change created: https://git.eclipse.org/r/148166
Comment 5 Lars Vogel CLA 2019-08-23 02:14:21 EDT
(In reply to Eclipse Genie from comment #4)
> New Gerrit change created: https://git.eclipse.org/r/148166

+1 approved by project lead for RC1.
Comment 7 Paul Pazderski CLA 2019-08-24 08:38:33 EDT
The breakpoint is now painted over the warning bulb (as for info in my screenshot in comment 1) but still below error light bulb.
Comment 8 Sarika Sinha CLA 2019-08-26 23:53:39 EDT
Eclipse SDK

Version: 2019-09 (4.13)
Build id: I20190826-1800
Comment 9 Vikas Chandra CLA 2019-11-28 05:57:04 EST
Nice enhancement!