Bug 549969 - [Dark Theme] sections, labels, and checkboxes have bright background in forms
Summary: [Dark Theme] sections, labels, and checkboxes have bright background in forms
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.13   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: 4.13 M3   Edit
Assignee: Ralph Gerbig CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2019-08-12 09:37 EDT by Ralph Gerbig CLA
Modified: 2019-08-16 10:51 EDT (History)
5 users (show)

See Also:

Attachments
Bright Background in MANIFEST.MF Editor (67.39 KB, image/png)
2019-08-12 09:37 EDT, Ralph Gerbig CLA 		no flags Details
Dark Background in MANIFEST.MF Editor (66.75 KB, image/png)
2019-08-12 09:40 EDT, Ralph Gerbig CLA 		no flags Details
Dark Background in MANIFEST.MF Editor (65.82 KB, image/png)
2019-08-12 09:47 EDT, Ralph Gerbig CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralph Gerbig CLA 2019-08-12 09:37:44 EDT 
Created attachment 279545 [details]
Bright Background in MANIFEST.MF Editor

I attached a screenshot of the MANIFEST.MF form based editor. All sections, labels and check boxes have a brighter background than the underlying form. In my opinion this looks like a bug when looking at the editor.
Comment 1 Ralph Gerbig CLA 2019-08-12 09:40:33 EDT 
Created attachment 279546 [details]
Dark Background in MANIFEST.MF Editor

MANIFEST.MF editor with patch applied.
Comment 2 Ralph Gerbig CLA 2019-08-12 09:47:18 EDT 
Created attachment 279547 [details]
Dark Background in MANIFEST.MF Editor
Comment 3 Julian Honnen CLA 2019-08-12 09:53:21 EDT 
Please submit your patch via gerrit: https://wiki.eclipse.org/Platform/How_to_Contribute
Comment 4 Ralph Gerbig CLA 2019-08-12 10:10:01 EDT 
https://git.eclipse.org/r/#/c/147547/
Comment 5 Julian Honnen CLA 2019-08-12 10:38:14 EDT 
Thanks! Apparently, it's a Platform issue after all - moving back
Comment 6 Matthias Becker CLA 2019-08-14 06:32:19 EDT 
Thank you Ralph for fixing this annoying issue.

CSS changes may have the risk of side-effects.
So the question is: Should we merge it now (for M3) or is it too risky?

I would vote for merging it. If we find side-effect we may fix them once we find them.
If we don't find a quick solution we can revert and work on fixing this again at the beginning of 4.14.

Would do the other platform committers think?
Comment 7 Lars Vogel CLA 2019-08-14 06:34:40 EDT 
(In reply to Matthias Becker from comment #6)
> Thank you Ralph for fixing this annoying issue.
> 
> CSS changes may have the risk of side-effects.
> So the question is: Should we merge it now (for M3) or is it too risky?

+1 for merge.
Comment 9 Julian Honnen CLA 2019-08-14 07:12:59 EDT 
Thanks Ralph!
Comment 10 Matthias Becker CLA 2019-08-16 10:36:24 EDT 
Let's provide a N&N Entry for this.
Comment 11 Eclipse Genie CLA 2019-08-16 10:50:22 EDT 
New Gerrit change created: https://git.eclipse.org/r/147843