Bug 549939 - Remove "Are you sure you want to " from text
Summary: Remove "Are you sure you want to " from text
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.13   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.13 M3   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2019-08-09 11:26 EDT by Lars Vogel CLA
Modified: 2019-08-21 17:06 EDT (History)
5 users (show)

See Also:


Attachments
Inconsistent phrases across products (34.36 KB, image/png)
2019-08-21 05:01 EDT, Sravan Kumar Lakkimsetti CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2019-08-09 11:26:57 EDT
Current we say something like:

Are you sure you want to delete the {0} selected resources from the file system?

I think we should shorten that a bit and I suggest to drop the "Are you sure you want to" part.
Comment 1 Lars Vogel CLA 2019-08-09 12:21:08 EDT
IMHO the "Are you sure you want to" phrase does not add value to the dialog.

Shorter texts are easier and faster to read. I suggest we shorten such usages in general.
Comment 2 Eclipse Genie CLA 2019-08-09 12:26:36 EDT
New Gerrit change created: https://git.eclipse.org/r/147390
Comment 3 Lars Vogel CLA 2019-08-13 07:51:23 EDT
Planning to merge tomorrow. 

Having less "boilerplate" text will hopefully beneficial for the user.
Comment 4 Eclipse Genie CLA 2019-08-14 04:16:13 EDT
New Gerrit change created: https://git.eclipse.org/r/147682
Comment 7 Eclipse Genie CLA 2019-08-14 04:51:02 EDT
New Gerrit change created: https://git.eclipse.org/r/147689
Comment 8 Eclipse Genie CLA 2019-08-14 04:51:04 EDT
New Gerrit change created: https://git.eclipse.org/r/147690
Comment 10 Dani Megert CLA 2019-08-14 08:36:30 EDT
Please see bug 550048 comment 8 and consider to revert this.
Comment 11 Lars Vogel CLA 2019-08-14 08:53:34 EDT
(In reply to Dani Megert from comment #10)
> Please see bug 550048 comment 8 and consider to revert this.

I think we currently have two developer groups:

1.) the first group tries to reject all changes which are not necessary. Bug 550048 comment 8 is IMHO one of such instances. I accepted that opinion as debug is not my primary development component.
2.) the second group would like to improve things even if they are not broken with the intention to improve the Eclipse IDe. I think the active developers in platform UI tend to be more in the second group.

For this reason I would suggest not to allow the option for platform UI. If more active platform UI developer dislike this change, I'm +1 for revert.
Comment 12 Alexander Kurtakov CLA 2019-08-14 09:10:58 EDT
The change aligns with Gnome HIG https://developer.gnome.org/hig/stable/dialogs.html.en and IMHO it makes it faster to understand what the question is.
Comment 13 Matthias Becker CLA 2019-08-15 02:37:43 EDT
If also vote to have shorter texts and remove the "Are you sure..." part
Comment 15 Sravan Kumar Lakkimsetti CLA 2019-08-21 05:01:16 EDT
Created attachment 279650 [details]
Inconsistent phrases across products

The dialog box phrases became inconsistent. In the attached dialog there are two dialog boxes from Egit and Platform. Since Egit is included in all EPP packages I consider that also part of eclipse product.

Now we have two dialog boxes with different phrases. This looks bad from end user perspective. I prefer usage of consistent phrases across one Eclipse product.  

Atleast in EPP packages we should have consistent use.
Comment 16 Lars Vogel CLA 2019-08-21 05:24:24 EDT
(In reply to Sravan Kumar Lakkimsetti from comment #15)
> Created attachment 279650 [details]
> Inconsistent phrases across products
> 
> The dialog box phrases became inconsistent. In the attached dialog there are
> two dialog boxes from Egit and Platform. Since Egit is included in all EPP
> packages I consider that also part of eclipse product.
> 
> Now we have two dialog boxes with different phrases. This looks bad from end
> user perspective. I prefer usage of consistent phrases across one Eclipse
> product.  
> 
> Atleast in EPP packages we should have consistent use.

I'm planning to provide Gerrits for EGit too.
Comment 17 Lars Vogel CLA 2019-08-21 05:35:23 EDT
IMHO the transition will be similar to the "action verbs" in dialogs in which we changed ok/cancel to something more descriptive. The platform moved first and other plugins followed.
Comment 18 Sravan Kumar Lakkimsetti CLA 2019-08-21 06:17:44 EDT
Ideally I would like to have a document/paper describing the guidelines for our enterprise customers(example Jboss, IBM rational tools, Intel tools etc). 

If it is already there, that needs to be enhanced with this change.
Comment 19 Lars Vogel CLA 2019-08-21 17:06:27 EDT
(In reply to Sravan Kumar Lakkimsetti from comment #15)
> Created attachment 279650 [details]
> Inconsistent phrases across products
> 
> The dialog box phrases became inconsistent. In the attached dialog there are
> two dialog boxes from Egit and Platform. Since Egit is included in all EPP
> packages I consider that also part of eclipse product.
> 
> Now we have two dialog boxes with different phrases. This looks bad from end
> user perspective. I prefer usage of consistent phrases across one Eclipse
> product.  
> 
> Atleast in EPP packages we should have consistent use.

EGit moved already to also use shorter text. https://git.eclipse.org/r/148069