Bug 549894 - Close Project via Middle-click
Summary: Close Project via Middle-click
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 4.12   Edit
Hardware: PC Windows 10
: P3 enhancement (vote)
Target Milestone: 4.13 M3   Edit
Assignee: Ünal Akkaya CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks: 563516
  Show dependency tree
 
Reported: 2019-08-08 12:18 EDT by Ünal Akkaya CLA
Modified: 2020-06-30 19:06 EDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ünal Akkaya CLA 2019-08-08 12:18:25 EDT
There is the action to open a closed project fast via double-click but no contrary fact closing via mouse events.

My proposal is to use the middle-click of the mouse to close an open project.
Comment 1 Eclipse Genie CLA 2019-08-08 12:19:25 EDT
New Gerrit change created: https://git.eclipse.org/r/147288
Comment 3 Alexander Fedorov CLA 2019-08-16 12:33:52 EDT
Thanks, Ünal!
Comment 4 Lars Vogel CLA 2019-08-16 12:46:14 EDT
Thanks. Please add to N&N.
Comment 5 Eclipse Genie CLA 2019-08-19 10:24:29 EDT
New Gerrit change created: https://git.eclipse.org/r/147924
Comment 7 Matthias Becker CLA 2019-08-20 07:06:30 EDT
verified with I20190819-2355
Comment 8 Vikas Chandra CLA 2019-08-22 06:54:26 EDT
(In reply to Eclipse Genie from comment #6)
> Gerrit change https://git.eclipse.org/r/147924 was merged to [master].
> Commit:
> http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/
> ?id=4388584619450b4621d410ea08a970961f3742a5


The image should be no more than 720 pixels wide and in PNG format (as opposed to GIF, TIF, BMP, or JPG).
Comment 9 Vikas Chandra CLA 2019-08-22 06:57:28 EDT
1) Shouldnt middle click work as open on  a closed project too?
2) Does the middle click work only on mouse ( because the trackpad on laptop thinkpad w541 middle click doesn't work)
3) Gif is not allowed in N&N
Comment 10 Vikas Chandra CLA 2019-08-22 07:57:08 EDT
>> Gif is not allowed in N&N


As per instructions.html doesn't allow gif, I have removed the gif image.
Comment 11 Ünal Akkaya CLA 2019-08-26 09:24:38 EDT
(In reply to Vikas Chandra from comment #9)
> 1) Shouldnt middle click work as open on  a closed project too?
> 2) Does the middle click work only on mouse ( because the trackpad on laptop
> thinkpad w541 middle click doesn't work)
> 3) Gif is not allowed in N&N

1) The default to open a closed project is double-click. But when you double-click on an opened project it will be collapsed -> I couldn't use double-click to close the project because this would be a change of behavior. So I used middle-click to close the project.
Currently, when a project is closed in the Project Explorer then the middle-click does nothing. This could be changed to open the closed project. I hadn't think of that.

2) The lenovo w541 has above the touchpad the left, right and scroll button. The scroll button is used for scrolling and thus does not trigger a mouse up event. I checked in the implementation and the mouse listener is not called when pressing the scroll button.

The lenovo p50 has buttons below the touchpad and there is the middle-button, with this the closing of projects works fine.

3) I've seen the change. Why is GIF not allowed?
For example VS Code (https://code.visualstudio.com/updates/v1_37) and Intelli J (https://www.jetbrains.com/idea/whatsnew/) are already using GIF which is much more useful and valuable than an image for some cases.
I would propose to adjust the rules and allow GIF, but it's up to the eclipse commiters. Is there an address where can I send my suggestions/feedback?
Comment 12 Matthias Becker CLA 2019-08-26 09:28:19 EDT
(In reply to Ünal Akkaya from comment #11)
> 3) I've seen the change. Why is GIF not allowed?
> For example VS Code (https://code.visualstudio.com/updates/v1_37) and
> Intelli J (https://www.jetbrains.com/idea/whatsnew/) are already using GIF
> which is much more useful and valuable than an image for some cases.
> I would propose to adjust the rules and allow GIF, but it's up to the
> eclipse commiters. Is there an address where can I send my
> suggestions/feedback?

You mean *animated* GIFs? Correct?
Comment 13 Ünal Akkaya CLA 2019-08-26 09:41:03 EDT
(In reply to Matthias Becker from comment #12)
> (In reply to Ünal Akkaya from comment #11)
> > 3) I've seen the change. Why is GIF not allowed?
> > For example VS Code (https://code.visualstudio.com/updates/v1_37) and
> > Intelli J (https://www.jetbrains.com/idea/whatsnew/) are already using GIF
> > which is much more useful and valuable than an image for some cases.
> > I would propose to adjust the rules and allow GIF, but it's up to the
> > eclipse commiters. Is there an address where can I send my
> > suggestions/feedback?
> 
> You mean *animated* GIFs? Correct?

Yes, animated GIFs.
Comment 14 Vikas Chandra CLA 2019-08-26 23:37:33 EDT
(In reply to Ünal Akkaya from comment #13)
> (In reply to Matthias Becker from comment #12)
> > (In reply to Ünal Akkaya from comment #11)
> > > 3) I've seen the change. Why is GIF not allowed?
> > > For example VS Code (https://code.visualstudio.com/updates/v1_37) and
> > > Intelli J (https://www.jetbrains.com/idea/whatsnew/) are already using GIF
> > > which is much more useful and valuable than an image for some cases.
> > > I would propose to adjust the rules and allow GIF, but it's up to the
> > > eclipse commiters. Is there an address where can I send my
> > > suggestions/feedback?
> > 
> > You mean *animated* GIFs? Correct?
> 
> Yes, animated GIFs.

I think it should be allowed. I will try to get "instructions.html" changed ( if possible).