Description Rolf Theunissen 2019-08-07 15:51:04 EDT

A first implementation of the showEditor/hideEditor methods are implemented in Bug 374132.

However, the corresponding tests are not enabled and many of them fail due to incorrect implementation of the methods. See the @Ignore TestOpen* testcases in IWorkbenchPageTest.
Some of the test seem trivial to fix, however probably EPartService and/or PartRenderingEngine need to be extended to correctly implement the full behavior.


Furthermore, from Bug 374132 comment 24:
The new implementation of these methods is incomplete and buggy. I've tried to use this instead of our current workaround and I've run into numerous issues:

1) Hidden editors are still returned in IWorkbenchPage.getEditorReferences(). According to the javadoc on IWorkbenchPage.hideEditors() they should not be returned in that list.

2) If there are multiple editor stacks in the editor area and all editors are hidden then the editor area is set to invisible and new editors will not be shown. When editors are hidden the CleanupAddon goes up the parents and sets both the part stacks  and the editor area to be invisible and opening a new editor won't change visibility so the editor is opened in an invisible stack and the user can't see it. When there is only one editor stack the CleanupAddon does not change the visibility of the stack.

3) Some parts of the UI still behave as though the editors are visible, for example if multiple editors are open and all are hidden except one then the context menu for the editor tab will show options like "Close tabs to the left", even though there is only a single tab visible.