549125 – Allow an extender/consumer of LSP4E's debug to provide an extended debug adapter protocol

Bug 549125 - Allow an extender/consumer of LSP4E's debug to provide an extended debug adapter protocol

Summary: Allow an extender/consumer of LSP4E's debug to provide an extended debug adap...

Status:	RESOLVED FIXED

Alias:	None

Product:	z_Archived
Classification:	Eclipse Foundation
Component:	LSP4E (show other bugs)
Version:	unspecified
Hardware:	All All

Importance:	P3 enhancement (vote)
Target Milestone:	---
Assignee:	Jonah Graham
QA Contact:

URL:
Whiteboard:
Keywords:	noteworthy

Depends on:
Blocks:	542488
	Show dependency tree

Reported:	2019-07-10 00:42 EDT by Jonah Graham
Modified:	2022-02-04 09:12 EST (History)
CC List:	2 users (show)

See Also:	Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jonah Graham

2019-07-10 00:42:29 EDT

To allow CDT to use LSP4E's debug adapter work, we need a way to have an extended debug adapter protocol in LSP4E.

Comment 1 Eclipse Genie

2019-07-10 00:44:06 EDT

New Gerrit change created: https://git.eclipse.org/r/145740

Comment 2 Eclipse Genie

2019-07-10 00:57:33 EDT

Gerrit change https://git.eclipse.org/r/145740 was merged to [master].
Commit: http://git.eclipse.org/c/lsp4e/lsp4e.git/commit/?id=ebb4ea676dd0ed1f658a7e156ceaff8f1ed7accf

Comment 3 Mickael Istria

2019-07-15 07:39:35 EDT

Cool, thanks.
Can you try to add a note about it in the "themes" for upcoming releases: https://projects.eclipse.org/projects/technology.lsp4e/releases/0.11.0/edit ? It's where I usually put the N&N-like items so far.

Comment 4 Jonah Graham

2019-07-15 10:25:15 EDT

Done.

This is what I put in as a first pass:

An extender of the LSP4E debug may have some extensions to the Debug Adapter Protocol they want to expose in Eclipse with additional UI elements. For example, a memory view can be enabled in the UI if the extender's extensions to the DAP support reading and writing memory. To allow this extenders can extend DSPLaunchDelegate, overriding the new createDebugTarget method. Within that method a specialized version of the DSPDebugTarget can be used that enables extended functionality. To make this easier, the DSPDebugTarget can be extended, overriding createLauncher, to create an LSP4J launcher that uses the extended interfaces.