Bug 548990 - [Quicksearch] Non-modal dialog search context never refreshed
Summary: [Quicksearch] Non-modal dialog search context never refreshed
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.13   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-04 15:14 EDT by Kris De Volder CLA
Modified: 2020-03-23 19:22 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kris De Volder CLA 2019-07-04 15:14:41 EDT 
Follow up ticket from: https://bugs.eclipse.org/bugs/show_bug.cgi?id=548518

See: 

    https://git.eclipse.org/r/#/c/145336/6/org.eclipse.text.quicksearch/src/org/eclipse/text/quicksearch/core/priority/DefaultPriorityFunction.java@126
    https://git.eclipse.org/r/#/c/145336/6/org.eclipse.text.quicksearch/src/org/eclipse/text/quicksearch/ui/QuickSearchContext.java@44

The search 'context' is created when the dialog is openened. It includes some data, such as for example a computed list of 'ignored' folders which can become stale over time. This is mostly relevant when the dialog is used in 'modeless' form so that it remains open even as the user continues to do other work.

Some mechanism should be added to 'refresh' the context, maybe something based on workspace listenener, or maybe it could be tied to the 'refresh' button that is already present in the dialog, or both. 

Another idea could be to refresh the context every time the dialog receives focus.