Bug 548988 - [Quicksearch] Cleanup mess around quicksearch menu contribution
Summary: [Quicksearch] Cleanup mess around quicksearch menu contribution
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.13   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-04 15:03 EDT by Kris De Volder CLA
Modified: 2020-03-23 19:22 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kris De Volder CLA 2019-07-04 15:03:44 EDT 
Follow up ticket from: https://bugs.eclipse.org/bugs/show_bug.cgi?id=548518

There's a big mess in quicksearch plugin.xml. It points to a potential issue in the platform (the mess was created in an apparant workaround to add a menu contribution to existing 'Search' menu in the proper way).

It is possible the problem in platform has since been fixed in which case the workaround should be removed. Otherwise, a bug should be raised to fix it in platform (and then the workaround removed).

See: 
https://git.eclipse.org/r/#/c/145336/6/org.eclipse.text.quicksearch/plugin.xml@18
https://git.eclipse.org/r/#/c/145336/6/org.eclipse.text.quicksearch/src/org/eclipse/text/quicksearch/ui/QuickSearchAction.java@23