Bug 548869 - Tabbing in Environment Variable Table unusable
Summary: Tabbing in Environment Variable Table unusable
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.13   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.13 M3   Edit
Assignee: Andrew Obuchowicz CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
: 548870 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-07-02 10:18 EDT by Andrew Obuchowicz CLA
Modified: 2019-08-20 02:25 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Obuchowicz CLA 2019-07-02 10:18:55 EDT 
The bug is shown with this change applied: https://git.eclipse.org/r/#/c/144298/

Currently, the bug renders the environment variables table unusable on Windows.  However, a stack trace error was observed on Linux by Mickael Istria. 

Steps to reproduce  the bug:
1. Run -> Run Configurations...
2. Select (or create) a run configuration (left side of the window that appears)
3. Go on the Environment tab 
4. Add a variable
5. Double-click the variable name and end edit *by pressing tab*

See Bug 548344 for screenshots the reproduce the issue, as well as a stack trace.

I've removed tab support for now.
Comment 1 Eric Williams CLA 2019-07-02 10:22:34 EDT 
*** Bug 548870 has been marked as a duplicate of this bug. ***
Comment 2 Eclipse Genie CLA 2019-07-06 17:49:25 EDT 
New Gerrit change created: https://git.eclipse.org/r/145570
Comment 4 Sarika Sinha CLA 2019-07-10 04:21:41 EDT 
From another bug,
The tab from value in the last row does not work. If there is a row after that, it moves to the next row Variable's name which is correct. If it's the last row, the tab from "Value" should just select the whole row or move to the bttons but current behaviour looks odd.

@Andrew,
Are you able to reproduce this?
Comment 5 Andrew Obuchowicz CLA 2019-07-10 14:33:26 EDT 
(In reply to Sarika Sinha from comment #4)
> From another bug,
> The tab from value in the last row does not work. If there is a row after
> that, it moves to the next row Variable's name which is correct. If it's the
> last row, the tab from "Value" should just select the whole row or move to
> the bttons but current behaviour looks odd.
> 
> @Andrew,
> Are you able to reproduce this?

Yes, I'm able to reproduce it and already have a working local patch to address this. 

I will be improving the patch and submitting the change soon.
Comment 6 Sarika Sinha CLA 2019-07-10 23:23:15 EDT 
Thanks Andrew!
I will keep it open for M3 as M1 is over now.
Comment 7 Eclipse Genie CLA 2019-07-19 15:03:10 EDT 
New Gerrit change created: https://git.eclipse.org/r/146399
Comment 8 Andrew Obuchowicz CLA 2019-07-19 15:07:17 EDT 
(In reply to Sarika Sinha from comment #6)
> Thanks Andrew!
> I will keep it open for M3 as M1 is over now.

@Sarika
I just sent the commit to fix the odd tab behavior :)
Comment 9 Eclipse Genie CLA 2019-07-22 09:31:20 EDT 
New Gerrit change created: https://git.eclipse.org/r/146455
Comment 11 Mickael Istria CLA 2019-07-22 09:56:08 EDT 
Thanks Andrew. Please add a note about it in https://www.eclipse.org/eclipse/news/4.13/platform.php#environment-table-improvements
Comment 12 Andrew Obuchowicz CLA 2019-07-22 10:23:25 EDT 
(In reply to Mickael Istria from comment #11)
> Thanks Andrew. Please add a note about it in
> https://www.eclipse.org/eclipse/news/4.13/platform.php#environment-table-
> improvements

Will do !
Comment 13 Mickael Istria CLA 2019-07-25 11:19:23 EDT 
(In reply to Andrew Obuchowicz from comment #12)
> Will do !

Done. Thanks Andrew!
Comment 14 Sarika Sinha CLA 2019-08-20 02:25:41 EDT 
Eclipse SDK

Version: 2019-09 (4.13)
Build id: I20190818-1800