548799 – [Platform] Replace usage of AbstractUIPlugin#imageDescriptorFromPlugin with new API from Bug 520080

Bug 548799 - [Platform] Replace usage of AbstractUIPlugin#imageDescriptorFromPlugin with new API from Bug 520080

Summary: [Platform] Replace usage of AbstractUIPlugin#imageDescriptorFromPlugin with n...

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	IDE (show other bugs)
Version:	4.13
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.13 M3
Assignee:	Alexander Fedorov
QA Contact:

URL:
Whiteboard:
Keywords:

Duplicates (1):	466703 (view as bug list)
Depends on:	551313
Blocks:	549861
	Show dependency tree

Reported:	2019-06-30 04:55 EDT by Lars Vogel
Modified:	2020-04-22 05:11 EDT (History)
CC List:	5 users (show)

See Also:	Gerrit Change Git Commit Gerrit Change Gerrit Change Git Commit Gerrit Change Gerrit Change Git Commit Git Commit Git Commit Gerrit Change Gerrit Change Git Commit Git Commit Gerrit Change Gerrit Change Git Commit Gerrit Change Git Commit Git Commit Gerrit Change Git Commit Gerrit Change Git Commit Gerrit Change Git Commit Gerrit Change 549442 Git Commit Gerrit Change Git Commit 549648 562389

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lars Vogel

2019-06-30 04:55:19 EDT

Once Bug 520080 is fixed, I suggest we replace the usage of AbstractUI#PluginimageDescriptorFromPlugin with the new API. 

Once this is done, we can deprecated AbstractUI#PluginimageDescriptorFromPlugin.

Comment 1 Eclipse Genie

2019-07-01 04:31:16 EDT

New Gerrit change created: https://git.eclipse.org/r/145203

Comment 2 Eclipse Genie

2019-07-01 06:12:37 EDT

Gerrit change https://git.eclipse.org/r/145203 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=6468478e7087699f91a61dd2954ccad01c5d3407

Comment 3 Alexander Fedorov

2019-07-01 06:46:49 EDT

Bug 548827 has been submitted to track API improvements

Comment 4 Eclipse Genie

2019-07-04 04:03:17 EDT

New Gerrit change created: https://git.eclipse.org/r/145452

Comment 5 Eclipse Genie

2019-07-04 04:10:31 EDT

New Gerrit change created: https://git.eclipse.org/r/145453

Comment 6 Eclipse Genie

2019-07-04 06:37:03 EDT

Gerrit change https://git.eclipse.org/r/145452 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=22eba29628d6d88dc2079e87c8745a739818688d

Comment 7 Eclipse Genie

2019-07-04 08:47:20 EDT

New Gerrit change created: https://git.eclipse.org/r/145473

Comment 8 Eclipse Genie

2019-07-04 09:24:02 EDT

New Gerrit change created: https://git.eclipse.org/r/145475

Comment 9 Eclipse Genie

2019-07-04 10:12:44 EDT

Gerrit change https://git.eclipse.org/r/145453 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=452a175668d59dd3ccadca6e1d216752ecf71f13

Comment 10 Eclipse Genie

2019-07-04 10:13:26 EDT

Gerrit change https://git.eclipse.org/r/145473 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2464bfe00c326c3913499123c4d799f6d0a91ece

Comment 11 Eclipse Genie

2019-07-04 12:02:04 EDT

Gerrit change https://git.eclipse.org/r/145475 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=11ca440d68cab8a3113d77e25a866db5d3898c5b

Comment 12 Eclipse Genie

2019-07-04 12:46:43 EDT

New Gerrit change created: https://git.eclipse.org/r/145488

Comment 13 Eclipse Genie

2019-07-04 12:50:56 EDT

New Gerrit change created: https://git.eclipse.org/r/145489

Comment 14 Eclipse Genie

2019-07-05 03:14:31 EDT

Gerrit change https://git.eclipse.org/r/145488 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=6c179cdcbf807eeef1b3d2dbb599cbd57f441afc

Comment 15 Eclipse Genie

2019-07-05 03:14:54 EDT

Gerrit change https://git.eclipse.org/r/145489 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=dbfff403a45519ebd8a4f42a87d925b6064e78bf

Comment 16 Eclipse Genie

2019-07-15 11:34:27 EDT

New Gerrit change created: https://git.eclipse.org/r/146094

Comment 17 Eclipse Genie

2019-07-15 12:20:12 EDT

New Gerrit change created: https://git.eclipse.org/r/146098

Comment 18 Eclipse Genie

2019-07-15 13:19:16 EDT

Gerrit change https://git.eclipse.org/r/146098 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=1e37aa628c6e341fffe93f50f27afe11cd10ac6e

Comment 19 Eclipse Genie

2019-07-15 13:36:40 EDT

New Gerrit change created: https://git.eclipse.org/r/146106

Comment 20 Eclipse Genie

2019-07-15 16:43:03 EDT

Gerrit change https://git.eclipse.org/r/146106 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.git/commit/?id=e051517ec06dd54863cf366ad2f0968c57b7e00e

Comment 21 Eclipse Genie

2019-07-16 03:04:04 EDT

Gerrit change https://git.eclipse.org/r/146094 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0ae2bbe5de620079a16440bbe9138462f7edfe29

Comment 22 Eclipse Genie

2019-07-16 03:23:14 EDT

New Gerrit change created: https://git.eclipse.org/r/146130

Comment 23 Eclipse Genie

2019-07-16 16:16:42 EDT

Gerrit change https://git.eclipse.org/r/146130 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=8345512e593e16475b8831622d96d84aca51b8b4

Comment 24 Eclipse Genie

2019-07-18 03:36:00 EDT

New Gerrit change created: https://git.eclipse.org/r/146291

Comment 25 Eclipse Genie

2019-07-18 08:42:28 EDT

Gerrit change https://git.eclipse.org/r/146291 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=47770c4052845dd93da22a50c254eece94b04c45

Comment 26 Paul Pazderski

2019-07-19 07:35:23 EDT

Another easy to miss user of imageDescriptorFromPlugin is PDE's plugin sample code.
https://git.eclipse.org/c/pde/eclipse.pde.ui.git/tree/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/wizards/plugin/PluginClassCodeGenerator.java#n142
Just noticed that while creating a new plugin.

Comment 27 Alexander Fedorov

2019-07-19 08:49:37 EDT

(In reply to Paul Pazderski from comment #26)
> Another easy to miss user of imageDescriptorFromPlugin is PDE's plugin
> sample code.
> https://git.eclipse.org/c/pde/eclipse.pde.ui.git/tree/ui/org.eclipse.pde.ui/
> src/org/eclipse/pde/internal/ui/wizards/plugin/PluginClassCodeGenerator.
> java#n142
> Just noticed that while creating a new plugin.

Thanks for this finding, Paul!
Do you think it will be better to have separate tickets for PDE and JDT?

Comment 28 Paul Pazderski

2019-07-19 09:12:11 EDT

If I knew, I'd have already made one. On one hand this ticket kind of implies "replace usage in Platform" but on the other hand you are an PDE committer so PDE is kind of informed already and a ticket may be overkill if it's only this template change.

I don't see the relation to JDT. If you mean replace usage of imageDescriptorFromPlugin in JDT I think a separate ticket is appropriate.

Comment 29 Julian Honnen

2019-07-19 10:51:56 EDT

(In reply to Paul Pazderski from comment #28)
> If I knew, I'd have already made one. On one hand this ticket kind of
> implies "replace usage in Platform" but on the other hand you are an PDE
> committer so PDE is kind of informed already and a ticket may be overkill if
> it's only this template change.

Please do create a PDE bug for improving the templates.

Comment 30 Eclipse Genie

2019-07-20 12:12:34 EDT

New Gerrit change created: https://git.eclipse.org/r/146412

Comment 31 Eclipse Genie

2019-07-20 14:20:23 EDT

Gerrit change https://git.eclipse.org/r/146412 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=137bc499bc3d1c24e091055173b690077b869954

Comment 32 Alexander Fedorov

2019-07-20 14:36:28 EDT

(In reply to Julian Honnen from comment #29)
> 
> Please do create a PDE bug for improving the templates.

Bug 549441 - [PDE] Rework usages of AbstractUIPlugin#imageDescriptorFromPlugin
Bug 549442 - [JDT] Rework usages of AbstractUIPlugin#imageDescriptorFromPlugin

Comment 33 Eclipse Genie

2019-07-21 04:18:01 EDT

New Gerrit change created: https://git.eclipse.org/r/146418

Comment 34 Eclipse Genie

2019-07-29 05:27:57 EDT

Gerrit change https://git.eclipse.org/r/146418 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ad46c70748d4d89aa16e36f1177f9c4f732735bb

Comment 35 Eclipse Genie

2019-07-29 10:31:06 EDT

New Gerrit change created: https://git.eclipse.org/r/146734

Comment 36 Eclipse Genie

2019-07-29 13:02:38 EDT

Gerrit change https://git.eclipse.org/r/146734 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c65a5ee60c39e140206e44c54b18fd7d0d30ae11

Comment 37 Lars Vogel

2020-02-24 13:07:03 EST

*** Bug 466703 has been marked as a duplicate of this bug. ***