Bug 548726 - p2-metadata's documentation of baselineMode and baselineReplace incomplete
Summary: p2-metadata's documentation of baselineMode and baselineReplace incomplete
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Tycho (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Jonah Graham CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation
Depends on:
Blocks:
 
Reported: 2019-06-27 13:51 EDT by Jonah Graham CLA
Modified: 2021-04-28 16:52 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonah Graham CLA 2019-06-27 13:51:42 EDT
There are some enums used in Tycho that don't seem to be documented. For example baselineMode and baselineReplace[1]. The enums do have reasonable javadoc, but they don't seem to be generating anything at the moment.

[1] https://www.eclipse.org/tycho/sitedocs/tycho-p2/tycho-p2-plugin/p2-metadata-default-mojo.html#baselineReplace
Comment 1 Jonah Graham CLA 2019-06-27 13:54:16 EDT
I am trying to figure out if/how this can be resolved by generating HTML from the enums. If not I will just list the options in the javadoc for where they are mentioned.
Comment 2 Jonah Graham CLA 2019-06-27 14:16:01 EDT
Seeing as other plugins (key ones like clean and compile) don't provide links/etc to complex types, I am not going to try too hard to auto-generate docs from enums. 

References: clean's filesets parameter does not document or even link automatically to complex type Fileset: https://maven.apache.org/plugins/maven-clean-plugin/clean-mojo.html#filesets

compile - which was written before enums existed - uses String type for something that is essentially an enum and the possible values are listed with String parameter. See compilerReuseStrategy as an example https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#compilerReuseStrategy

So I will just add to the options in the parameter's javadoc. This will at least save the next person from having to get the source code to find out what the legal values are.
Comment 4 Eclipse Genie CLA 2019-06-27 14:35:38 EDT
New Gerrit change created: https://git.eclipse.org/r/145060
Comment 5 Mickael Istria CLA 2019-06-27 15:08:38 EDT
Thanks Jonah!