Bug 548650 - Add support for multi-line input to StringFieldEditor
Summary: Add support for multi-line input to StringFieldEditor
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.13   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.13 M1   Edit
Assignee: Kris De Volder CLA
QA Contact:
URL:
Whiteboard:
Keywords: api, noteworthy
Depends on:
Blocks:
 
Reported: 2019-06-25 17:48 EDT by Kris De Volder CLA
Modified: 2019-06-29 01:55 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kris De Volder CLA 2019-06-25 17:48:54 EDT 
For some background see: https://bugs.eclipse.org/bugs/show_bug.cgi?id=548518

Summary, to be able to re-use rather than duplicate most of the code in StringFieldEditor we need it to allow creating a text widget that supports larger text that can have multiple lines and wrap / scroll the text.

I am submitting a patch for this shortly.
Comment 1 Eclipse Genie CLA 2019-06-25 17:57:28 EDT 
New Gerrit change created: https://git.eclipse.org/r/144891
Comment 2 Kris De Volder CLA 2019-06-26 15:38:24 EDT 
Where do I get these?

 org.eclipse.test.performance,
 org.eclipse.core.tests.harness,

Seems needed for the test code to compile. 

Readme is talking about installing hamcrest and friends from orbit but I have no idea where these two bundles are coming from.
Comment 3 Paul Pazderski CLA 2019-06-26 15:49:38 EDT 
Performance is in eclipse.platform.releng.git and harness is in eclipse.platform.runtime.git.

You might get them from Eclipse SDK Tests but I would not recommend to install them in your work IDE.

Probably the easiest way for a non oomph setup is to just import the two projects from git.
Comment 5 Mickael Istria CLA 2019-06-28 10:21:43 EDT 
@Kris: can you please add a note about it in the N&N document?
Comment 6 Kris De Volder CLA 2019-06-28 17:11:09 EDT 
> can you please add a note about it in the N&N document?

Does that really make sense? This is really not something a user will see since the 'multi-line' StringFieldEditor isn't used by anything (yet).

Once it is used by something, like quicksearch, then it probably make more sense to add a note about the thing that uses it (like quicksearch).
Comment 7 Mickael Istria CLA 2019-06-28 17:15:25 EDT 
(In reply to Kris De Volder from comment #6)
> This is really not something a user will see
> since the 'multi-line' StringFieldEditor isn't used by anything (yet).

It definitely make sense in "noteworthy for plugin developers" https://www.eclipse.org/eclipse/news/4.13/pde.php , just like most new APIs.
Comment 8 Mickael Istria CLA 2019-06-28 17:16:38 EDT 
(In reply to Mickael Istria from comment #7)
> It definitely make sense in "noteworthy for plugin developers"
> https://www.eclipse.org/eclipse/news/4.13/pde.php , just like most new APIs.

But I see it's not systematically the case. I'll start a thread on the platform-dev mailing-list to gather other opinions.
Comment 9 Mickael Istria CLA 2019-06-28 17:18:49 EDT 
(In reply to Mickael Istria from comment #8)
> (In reply to Mickael Istria from comment #7)
> > It definitely make sense in "noteworthy for plugin developers"
> > https://www.eclipse.org/eclipse/news/4.13/pde.php , just like most new APIs.
> 
> But I see it's not systematically the case. I'll start a thread on the
> platform-dev mailing-list to gather other opinions.

OK, this is the page I was looking for https://www.eclipse.org/eclipse/news/4.13/platform_isv.php . Please add a note about the new capability here.
Comment 10 Eclipse Genie CLA 2019-06-28 18:50:28 EDT 
New Gerrit change created: https://git.eclipse.org/r/145147