Bug 548628 - Wayland as Input method is accessible in X11
Summary: Wayland as Input method is accessible in X11
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.13   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.13 M1   Edit
Assignee: Eric Williams CLA
QA Contact:
URL:
Whiteboard: RHT
Keywords: triaged
: 552084 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-06-25 08:47 EDT by Martin Coufal CLA
Modified: 2019-11-11 16:01 EST (History)
4 users (show)

See Also:

Attachments
error log (276.61 KB, text/x-log)
2019-06-25 08:47 EDT, Martin Coufal CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Coufal CLA 2019-06-25 08:47:03 EDT 
Created attachment 279071 [details]
error log

It is possible to set 'Wayland' as input method while running X11. This causes SIGSEGV at [libwayland-client.so.0+0x6608] wl_proxy_marshal_constructor+0x88.

Enclosing full crash report.

Steps to reproduce:
1) have X11 running (not Wayland)
2) run Eclipse
2) create new project with new file
3) open file with 'Text Editor'
4) right click inside the editor
5) select 'Input Methods' -> 'Wayland' in the context menu

Java crashes on SIGSEGV and Eclipse is closed.

Environment:
* RHEL-8.0 + X11
* Eclipse 4.13 (I20190624-1800)
* Java 8 (1.8.0_201)
* gtk2-2.24.32
Comment 1 Eric Williams CLA 2019-06-25 09:11:06 EDT 
Are you sure this is supposed to be possible? My understanding was that anything Wayland related is impossible on X11 unless you have an instance of the Wayland compositor running somewhere.
Comment 2 Martin Coufal CLA 2019-06-25 09:37:19 EDT 
(In reply to Eric Williams from comment #1)
> Are you sure this is supposed to be possible? My understanding was that
> anything Wayland related is impossible on X11 unless you have an instance of
> the Wayland compositor running somewhere.

I may have expressed myself incorrectly. I don't think this should be possible. But the option shouldn't be visible, or at least, it shouldn't crash and input method should stay as before.
Comment 3 Eric Williams CLA 2019-06-25 12:29:37 EDT 
(In reply to Martin Coufal from comment #2)
> (In reply to Eric Williams from comment #1)
> > Are you sure this is supposed to be possible? My understanding was that
> > anything Wayland related is impossible on X11 unless you have an instance of
> > the Wayland compositor running somewhere.
> 
> I may have expressed myself incorrectly. I don't think this should be
> possible. But the option shouldn't be visible, or at least, it shouldn't
> crash and input method should stay as before.

Oh, yes that makes total sense. I'll look into it.
Comment 4 Andrey Loskutov CLA 2019-06-26 03:07:38 EDT 
+1 if we want remove "Input Methods" menu altogether. Just got a customer request complaining about the annoying menu :-)
Comment 5 Andrey Loskutov CLA 2019-06-26 03:08:36 EDT 
(In reply to Andrey Loskutov from comment #4)
> +1 if we want remove "Input Methods" menu altogether. Just got a customer
> request complaining about the annoying menu :-)

Or at least add a system property that allows us to hide it (or to show it), depending on what we want to be as default.
Comment 6 Eric Williams CLA 2019-06-26 10:38:36 EDT 
There isn't a distro on the target environments list that's old enough *not* to have an input method setting in the desktop environment. So I'm just going to remove this menu. :)
Comment 7 Eclipse Genie CLA 2019-06-26 14:50:31 EDT 
New Gerrit change created: https://git.eclipse.org/r/144954
Comment 9 Eric Williams CLA 2019-06-26 15:33:08 EDT 
(In reply to Eclipse Genie from comment #8)
> Gerrit change https://git.eclipse.org/r/144954 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=4f13ff5551300f17a97860a20c3b34c3aacd2917

In master now.
Comment 10 Andrey Loskutov CLA 2019-06-26 15:41:38 EDT 
Should we add a note in N&N?
Comment 11 Eric Williams CLA 2019-06-26 15:46:14 EDT 
(In reply to Andrey Loskutov from comment #10)
> Should we add a note in N&N?

Sure, I can add one.
Comment 12 Eclipse Genie CLA 2019-06-26 16:11:10 EDT 
New Gerrit change created: https://git.eclipse.org/r/144956
Comment 14 Martin Coufal CLA 2019-07-01 07:57:55 EDT 
Tested on I20190630-1800. Option 'Input Method' is gone.
Comment 15 Eric Williams CLA 2019-11-11 16:01:56 EST 
*** Bug 552084 has been marked as a duplicate of this bug. ***