Bug 548457 - [Win32] Replace direct vtable calls with interface wrappers
Summary: [Win32] Replace direct vtable calls with interface wrappers
Status: CLOSED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.13   Edit
Hardware: PC Windows All
: P3 enhancement (vote)
Target Milestone: 4.13 M1   Edit
Assignee: Nikita Nemkin CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 548458 549414 551091
  Show dependency tree
 
Reported: 2019-06-20 02:53 EDT by Nikita Nemkin CLA
Modified: 2019-10-08 05:21 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Nemkin CLA 2019-06-20 02:53:58 EDT 
Widgets code uses direct vtable calls (OS.VtblCall) to interact with COM objects. The reason is avoiding dependency on o.e.s.internal.ole.win32.

There's no point in avoiding this dependency anymore. Let's improve the code by using proper interface wrappers everywhere.
Comment 1 Eclipse Genie CLA 2019-06-20 03:07:45 EDT 
New Gerrit change created: https://git.eclipse.org/r/144512
Comment 2 Niraj Modi CLA 2019-06-21 04:17:49 EDT 
(In reply to Nikita Nemkin from comment #0)
> Widgets code uses direct vtable calls (OS.VtblCall) to interact with COM
> objects. The reason is avoiding dependency on o.e.s.internal.ole.win32.
> 
> There's no point in avoiding this dependency anymore. Let's improve the code
> by using proper interface wrappers everywhere.

+1.
This refactoring makes the code lot readable as well. Just saw the patch which requires manual re-base.

(In reply to Eclipse Genie from comment #1)
> New Gerrit change created: https://git.eclipse.org/r/144512
Comment 3 Paul Pazderski CLA 2019-06-21 05:40:30 EDT 
(In reply to Niraj Modi from comment #2)
> This refactoring makes the code lot readable as well.

+1. Found those VtblCall quite confusing the first time I looked into Win32 SWT code.