Bug 548385 - Activate the UI freeze monitor in our product configuration for the SDK
Summary: Activate the UI freeze monitor in our product configuration for the SDK
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.11   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.13 RC1   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy, performance
Depends on:
Blocks: 550209
  Show dependency tree
 
Reported: 2019-06-18 07:54 EDT by Lars Vogel CLA
Modified: 2019-08-23 08:43 EDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2019-06-18 07:54:40 EDT 
IMHO it would be nice if the Eclipse SDK has the UI freeze monitor activated by default. As our SDK does not target end users (EPPs do that), this would help us to identifier easier potential performance bottlenecks.

I'm not suggest to change the preference default, only to configure our SDK with this via the preference configuration.
Comment 1 Lars Vogel CLA 2019-06-18 07:55:39 EDT 
Any concerns here from our performance experts?
Comment 2 Julian Honnen CLA 2019-06-18 08:09:14 EDT 
I haven't noticed any slowdowns caused by the freeze monitoring.
Comment 3 Karsten Thoms CLA 2019-06-18 09:48:29 EDT 
I like the idea. Just to be clear: Users downloading an Eclipse package (including via Eclipse Installer) won't recognise a change in behavior. Just SDK developers will have that on by default?
Comment 4 Lars Vogel CLA 2019-08-09 09:35:52 EDT 
(In reply to Karsten Thoms from comment #3)
> I like the idea. Just to be clear: Users downloading an Eclipse package
> (including via Eclipse Installer) won't recognise a change in behavior. Just
> SDK developers will have that on by default?

Yes
Comment 5 Eclipse Genie CLA 2019-08-13 06:07:43 EDT 
New Gerrit change created: https://git.eclipse.org/r/147601
Comment 8 Lars Vogel CLA 2019-08-13 11:49:54 EDT 
Done, will check tomorrow I-build if it picks up the new preference from the ini file.
Comment 9 Dani Megert CLA 2019-08-14 05:24:08 EDT 
(In reply to Eclipse Genie from comment #7)
> Gerrit change https://git.eclipse.org/r/147606 was merged to [master].
> Commit:
> http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=1b2a013e5053e9c42aeb6b5c744a113134e6d320
> 
I would add how/where users can disable this if it causes too much noise.
Comment 10 Lars Vogel CLA 2019-08-14 05:24:37 EDT 
(In reply to Dani Megert from comment #9)
> (In reply to Eclipse Genie from comment #7)
> > Gerrit change https://git.eclipse.org/r/147606 was merged to [master].
> > Commit:
> > http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=1b2a013e5053e9c42aeb6b5c744a113134e6d320
> > 
> I would add how/where users can disable this if it causes too much noise.

Will do.
Comment 11 Eclipse Genie CLA 2019-08-14 05:33:02 EDT 
New Gerrit change created: https://git.eclipse.org/r/147696
Comment 13 Eclipse Genie CLA 2019-08-23 04:28:42 EDT 
New Gerrit change created: https://git.eclipse.org/r/148180
Comment 14 Lars Vogel CLA 2019-08-23 04:51:32 EDT 
+1 from project lead to revert the setting for platform.
Comment 16 Andrey Loskutov CLA 2019-08-23 07:21:40 EDT 
(In reply to Lars Vogel from comment #14)
> +1 from project lead to revert the setting for platform.

Lars, if this is now reverted back, we should also update N&N saying the opposite.
Comment 17 Lars Vogel CLA 2019-08-23 07:26:13 EDT 
(In reply to Andrey Loskutov from comment #16)
> (In reply to Lars Vogel from comment #14)
> > +1 from project lead to revert the setting for platform.
> 
> Lars, if this is now reverted back, we should also update N&N saying the
> opposite.

It is still set for the SDK as the N&N says.