Bug 548071 - [Preferences] Improve tab display/organization for SSH2 preferences page
Summary: [Preferences] Improve tab display/organization for SSH2 preferences page
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 4.13   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform Team Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks: 548042
  Show dependency tree
 
Reported: 2019-06-07 14:56 EDT by Andrew Obuchowicz CLA
Modified: 2019-08-02 10:47 EDT (History)
1 user (show)

See Also:


Attachments
Image demonstrating the SSH2 tabs getting cut off by the window (53.25 KB, image/png)
2019-06-07 14:58 EDT, Andrew Obuchowicz CLA
no flags Details
Suggested solution (tab with a dropdown of all hidden tabs) (194.90 KB, image/png)
2019-06-07 14:59 EDT, Andrew Obuchowicz CLA
no flags Details
Suggested Solution: TabFolder Paging (8.61 KB, image/png)
2019-06-10 12:09 EDT, Andrew Obuchowicz CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Obuchowicz CLA 2019-06-07 14:56:36 EDT
Where it occurs:
Preferences -> General -> Network Connections -> SSH2

Problem:
When the preference window's width is too small, the tabs at the top of the window get cut off, potentially leaving them unreadable and hidden from the user.
(See first attached image)

Suggested Solution:
Implement the same solution used when managing multiple editor tabs in the Java Perspective: have a button which is a drop down of all of the tabs which are not currently visible due to the window's size.
(See second attached image)
Comment 1 Andrew Obuchowicz CLA 2019-06-07 14:58:30 EDT
Created attachment 278864 [details]
Image demonstrating the SSH2 tabs getting cut off by the window
Comment 2 Andrew Obuchowicz CLA 2019-06-07 14:59:24 EDT
Created attachment 278865 [details]
Suggested solution (tab with a dropdown of all hidden tabs)
Comment 3 Andrew Obuchowicz CLA 2019-06-10 12:08:16 EDT
(In reply to Andrew Obuchowicz from comment #0)
> Suggested Solution:
> Implement the same solution used when managing multiple editor tabs in the
> Java Perspective: have a button which is a drop down of all of the tabs
> which are not currently visible due to the window's size.
> (See second attached image)

Please ignore this suggestion as it involves using CTabFolder.
[Revised Suggested Solution]:
Make use of TabFolder's paging ability to allow the (currently hidden) tabs to be organized and easily accessible. 

Here is a snippet demonstrating TabFolder Paging:
http://www.java2s.com/Code/Java/SWT-JFace-Eclipse/SWTTabControl.htm
Comment 4 Andrew Obuchowicz CLA 2019-06-10 12:09:56 EDT
Created attachment 278879 [details]
Suggested Solution: TabFolder Paging
Comment 5 Andrew Obuchowicz CLA 2019-08-02 10:47:45 EDT
I'm currently unable to make progress on this bug as changing CTabFolder into TabFolder breaks the dark theme on Windows. It appears TabFolders have limited styling/theming support on Windows/Win32, and can not have their color modified to fit the Dark Theme.