Community
Participate
Working Groups
Where it occurs: Preferences → Editors → Text Editors (near the middle of the window) There is a missing space character between "Show whitespace characters" and "(configure visiblity)". Should be changed to: "Show whitespace characters (configure visibility)" instead of: "Show whitespace characters(configure visibility)"
Created attachment 278855 [details] Image of missing spacing
This is on Linux? Which font? On Windows 7 this looks OK. Screenshot to follow.
Created attachment 278897 [details] No issue on Windows 7
(In reply to Dani Megert from comment #2) > This is on Linux? Which font? > > On Windows 7 this looks OK. Screenshot to follow. Thank you for confirming - this must be a Linux problem (unless it is also occurring on OSX which I am unable to confirm, personally).
(In reply to Andrew Obuchowicz from comment #4) > (In reply to Dani Megert from comment #2) > > This is on Linux? Which font? > > > > On Windows 7 this looks OK. Screenshot to follow. > > Thank you for confirming - this must be a Linux problem (unless it is also > occurring on OSX which I am unable to confirm, personally). Looks fine on Mac too. Which version of Eclipse are you using?
I can reproduce this on Ubuntu 18.04. Looks like linux specific problem
I can reproduce the issue on Fedora 30, GTK 3.24, 4.12.
*** Bug 550937 has been marked as a duplicate of this bug. ***
I don't get any space in this place. It's driving me mad! I'll push a change which adds some spacing between the checkbox control and the link control. This makes the GUI looks like good for me, but maybe there is a little too much space on Windows and Mac. But I figure that the resulting situation will be better: No space on Linux probably looks worse than a little too much space on Windows and Mac. I guess that the cause is that these controls have different amount of padding on GTK, Windows and Cocoa. I use Lubuntu 18.03 with GTK 3.22.30.
New Gerrit change created: https://git.eclipse.org/r/154753
Created attachment 281268 [details] Space before and after change on Windows 10 IMO ok on Windows.
(In reply to Paul Pazderski from comment #11) > Space before and after change on Windows 10 Thanks Paul! I can make the space a little smaller. That would still look good on Linux and look a little better on Windows.
(In reply to Jens Lideström from comment #12) > (In reply to Paul Pazderski from comment #11) > > Space before and after change on Windows 10 > > Thanks Paul! > > I can make the space a little smaller. That would still look good on Linux > and look a little better on Windows. Mac would also look worse. So, only make the change when running on GTK.
(In reply to Dani Megert from comment #13) > Mac would also look worse. So, only make the change when running on GTK. Hm... I see your point. But I think the small layout inperfection (a tiny bit to small on Linux, and tiny bit to long on Windows and Mac) warrants any kind of special casing. Also, if this SWT platform difference changes in the future, it is more likeley that that layout will be weird if we add special casing. I vote for simply adding space on all platform.
(In reply to Jens Lideström from comment #14) > I vote for simply adding space on all platform. -1 for that. The amount of users that get hurt is bigger than those who would profit.
(In reply to Dani Megert from comment #15) > -1 for that. The amount of users that get hurt is bigger than those who > would profit. Alright. I'll update the change to that effect.
Could this difference in layout with checkboxes and links be an SWT bug? I will not investigate, but maybe somebody else feels the inspiration to do that...
Gerrit change https://git.eclipse.org/r/154753 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=1d9720c8d026ac8c066a0c92f09e1821ded543ee
Thanks for fixing this Jens :)
verified on Eclipse SDK Version: 2020-03 (4.15) Build id: I20200106-1805 OS: Linux, v.4.15.0-72-generic, x86_64 / gtk 3.22.30 Java version: 14-ea
