547935 – [Snippets] Add preview image for SWT Snippets

Bug 547935 - [Snippets] Add preview image for SWT Snippets

Summary: [Snippets] Add preview image for SWT Snippets

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	SWT (show other bugs)
Version:	4.12
Hardware:	All All

Importance:	P3 enhancement (vote)
Target Milestone:	4.13 M1
Assignee:	Paul Pazderski
QA Contact:	Eric Williams

URL:
Whiteboard:
Keywords:	triaged

Depends on:
Blocks:

Reported:	2019-06-04 17:56 EDT by Paul Pazderski
Modified:	2019-07-10 11:24 EDT (History)
CC List:	3 users (show)

See Also:	Gerrit Change Gerrit Change Git Commit Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Paul Pazderski

2019-06-04 17:56:28 EDT

I think it would be nice to have preview images for the Snippets.

Besides that I want to include the previews in my SnippetExplorer. (bug 547934)

I made previews for (almost) all Snippets where appropriate. Missing are Applet Snippets and Windows OLE Snippets requiring Microsoft Office (and maybe a few more).

Comment 1 Eclipse Genie

2019-06-04 17:58:18 EDT

New Gerrit change created: https://git.eclipse.org/r/143308

Comment 2 Eclipse Genie

2019-06-04 17:59:31 EDT

New Gerrit change created: https://git.eclipse.org/r/143309

Comment 3 Eclipse Genie

2019-06-10 13:36:57 EDT

Gerrit change https://git.eclipse.org/r/143308 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=eed6d110a0fdfc426f0aac789257f5c5e98c6c96

Comment 4 Eclipse Genie

2019-06-11 02:46:03 EDT

Gerrit change https://git.eclipse.org/r/143309 was merged to [master].
Commit: http://git.eclipse.org/c/www.eclipse.org/swt.git/commit/?id=0751d14f80c0f8e133f0ed0c76c738ee9297b26a

Comment 5 Lakshmi P Shanmugam

2019-06-11 04:01:57 EDT

Thanks for the improvements, Paul!

Comment 6 Nikita Nemkin

2019-06-11 06:36:32 EDT

Was it really necessary to add this? I see no benefit whatsoever.

Comment 7 Eric Williams

2019-06-11 09:06:57 EDT

(In reply to Nikita Nemkin from comment #6)
> Was it really necessary to add this? I see no benefit whatsoever.

If you run the new SnippetExplorer, it will show an image of what the snippet looks like. Very useful IMO if you are hunting for a specific snippet where you know what it looks like, but can't remember the number.

Comment 8 Lakshmi P Shanmugam

2019-06-12 02:54:43 EDT

(In reply to Nikita Nemkin from comment #6)
> Was it really necessary to add this? I see no benefit whatsoever.

Try out the new SnippetExplorer... I think it's really cool to have the previews in the SnippetExplorer! You can see how the snippet will look without running it.
It's very useful when you work with snippets often.

Comment 9 Eric Williams

2019-06-18 14:00:57 EDT

In master now.

Comment 10 Eric Williams

2019-07-10 11:24:02 EDT

Verified in I20190710-0610.