Bug 54710 - [Contexts] Renamed EnabledSubmission to ContextSubmission
Summary: [Contexts] Renamed EnabledSubmission to ContextSubmission
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Douglas Pollock CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2004-03-12 16:54 EST by Jared Burns CLA
Modified: 2004-11-02 11:13 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Burns CLA 2004-03-12 16:54:34 EST
The type EnabledSubmission would be better named ContextSubmission. Clients browsing for 
context-related APIs generally look for types named *context*. Since the name has no relation to 
contexts, it's difficult to remember. And lastly, the name is almost oxymoronic. While the API may 
say "add" and "remove" EnabledSubmissions, clients logically think of this as enabling and 
disabling the submissions. Just saying "then we disable our EnabledSubmission" makes my head 
hurt. :)

I think it's cleaner to call them ContextSubmissions, because that's what clients are really doing - 
submitting a context.
Comment 1 Chris McLaren CLA 2004-03-18 11:39:40 EST
as people don't really like the word 'submission', how about this:
EnableRequest (and in the commands API, HandleRequest)

other options might be (but i prefer the above..):
RequestToEnable, RequestToEnableContext.

the API methods could change to addEnableRequests(..), etc?
lemme know..

p.s. i don't like ContextSubmission or variants, especially because of its
equivalent in the commands API: CommandSubmission is confusing, when I'm really
requesting a handler for a command. In the future there might need to be other
properties of a command (or even context) contributed in this way, so i'd like
to leave the names more specific. 
Comment 2 Douglas Pollock CLA 2004-11-02 11:12:35 EST
Too late, I think.  This is API now. 
Comment 3 Douglas Pollock CLA 2004-11-02 11:13:12 EST
wontfix