Bug 546929 - N&N entry not understandable and image not readable
Summary: N&N entry not understandable and image not readable
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Doc (show other bugs)
Version: 4.12   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.12 RC1   Edit
Assignee: Mickael Istria CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 500388
Blocks:
  Show dependency tree
 
Reported: 2019-05-02 10:16 EDT by Dani Megert CLA
Modified: 2019-05-31 10:53 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2019-05-02 10:16:00 EDT 
4.12 M1.

N&N entry not understandable and image not readable.

See https://www.eclipse.org/eclipse/news/4.12/platform.php#pass-directory-to-launcher

I tested this on Windows and the field is empty. From the text I don't really understand what
"When a directory name is passed to the Eclipse launcher on command-line " means.
Comment 1 Dani Megert CLA 2019-05-24 12:43:39 EDT 
Mickael, please fix for RC1.
Comment 2 Mickael Istria CLA 2019-05-25 12:26:13 EDT 
"not understandable" is too vague to be easily fixed. Maybe you can suggest a better way of describing the feature.
As for image size, this feature cannot be shown in the given width constraints. So I had to make a screenshot on a regular size and scale it, and scale induces blur. I don't know I could make that better.
Comment 3 Kalyan Prasad Tatavarthi CLA 2019-05-28 07:07:20 EDT 
@Mickael One observation is that if an instance of eclipse is already running, and we run ./eclipse.exe DIR_PATH , the the new eclipse version is not launched, but the Smart import wizard is shown on existing running instace of  Eclipse. Is this the expected behavior and if so, this also needs to be updated in the Readme.
Comment 4 Mickael Istria CLA 2019-05-28 07:14:17 EDT 
(In reply to Kalyan Prasad Tatavarthi from comment #3)
> @Mickael One observation is that if an instance of eclipse is already
> running, and we run ./eclipse.exe DIR_PATH , the the new eclipse version is
> not launched, but the Smart import wizard is shown on existing running
> instace of  Eclipse. Is this the expected behavior and if so, this also
> needs to be updated in the Readme.

Yes, I think the expected behavior. It's the same behavior for the existing `eclipse /path/to/file` command.
Comment 5 Dani Megert CLA 2019-05-30 09:44:08 EDT 
(In reply to Mickael Istria from comment #4)
> (In reply to Kalyan Prasad Tatavarthi from comment #3)
> > @Mickael One observation is that if an instance of eclipse is already
> > running, and we run ./eclipse.exe DIR_PATH , the the new eclipse version is
> > not launched, but the Smart import wizard is shown on existing running
> > instace of  Eclipse. Is this the expected behavior and if so, this also
> > needs to be updated in the Readme.
> 
> Yes, I think the expected behavior. It's the same behavior for the existing
> `eclipse /path/to/file` command.
OK, can you please adjust the N&N entry accordingly.

The blurry image is useless as one can't really see anything. Maybe just show the relevant part of the wizard.
Comment 6 Eclipse Genie CLA 2019-05-31 06:07:18 EDT 
New Gerrit change created: https://git.eclipse.org/r/143108