Bug 546634 - StackRenderer should only use model elements to determine view-menu visibility
Summary: StackRenderer should only use model elements to determine view-menu visibility
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.11   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on: 543827
Blocks: 467000
  Show dependency tree
 
Reported: 2019-04-22 14:50 EDT by Rolf Theunissen CLA
Modified: 2021-04-23 12:30 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rolf Theunissen CLA 2019-04-22 14:50:41 EDT 
The hasVisibleMenuItems method of the StackRenderer is used to determine if the view-menu should be shown. Currently, when the E4 model is not up to date, the implementation falls back to check the actual SWT menu items to check visibility.

The StackRenderer should only use model elements and render methods to determine visibility:
0. The E4 model must be up to date with the model (see bug 543827)
1. Call update visible items on the viewmenu
2. Check for visibility of the menu items
Comment 1 Eclipse Genie CLA 2021-04-23 12:30:36 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.