Bug 545994 - [GTK3][Tree] Visible area moved when only expanding element
Summary: [GTK3][Tree] Visible area moved when only expanding element
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.12   Edit
Hardware: PC Linux
: P3 major (vote)
Target Milestone: 4.12 M1   Edit
Assignee: Xi Yan CLA
QA Contact:
URL:
Whiteboard:
Keywords: regression, triaged
Depends on:
Blocks:
 
Reported: 2019-04-01 04:00 EDT by Mickael Istria CLA
Modified: 2019-04-08 17:46 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mickael Istria CLA 2019-04-01 04:00:30 EDT 
I'm using Eclipse SDK I20190327-1800
In Project Explorer, I have "Link with Editor" enabled.
Whenever I only expand an element in the tree, the visible area of the tree is moved back to the top, and I have to scroll again to re-find the element I was playing with.
If I don't have "Link with Editor" enabled, it's fine.
Comment 1 Mickael Istria CLA 2019-04-01 04:01:10 EDT 
This looks like a regression over previous release.
Comment 2 Mickael Istria CLA 2019-04-01 04:03:25 EDT 
Actually, that doesn't seem related to "Link with Editor", I disabled it and still see the issue. My former analysis probably missed another criterion.
Comment 3 Andrey Loskutov CLA 2019-04-01 04:18:11 EDT 
(In reply to Mickael Istria from comment #2)
> Actually, that doesn't seem related to "Link with Editor", I disabled it and
> still see the issue. My former analysis probably missed another criterion.

Mickael, I guess you are on Linux? If yes, this is SWT issue, there were some "Tree" changes in 4.12.
Comment 4 Mickael Istria CLA 2019-04-01 04:25:27 EDT 
Indeed, I'm on Linux.
I guess it's SWT issue, but since so far I've only reproduced it in the Project Explorer (and not the Preference or other trees for instance), I thought a dedicated bug would help tracking the various possible cases of SWT bugs.
Comment 5 Andrey Loskutov CLA 2019-04-01 04:30:25 EDT 
Mickael, can you please provide exact steps to reproduce?
Comment 6 Andrey Loskutov CLA 2019-04-01 04:41:06 EDT 
I see this in Package Explorer too, in I20190331-1800

Steps:

1) Package Explorer contains lot of projects.
2) Make sure tree has V scrollbar, so 50% of the content is hidden.
3) Scroll to the project in the middle.
4) Expand one of the children elements.
5) Tree scrolls to the top.
6) Scroll back and try to collapse/expand same element => no jumps.
7) Expand next element => tree scrolls to the top again.
Comment 7 Eric Williams CLA 2019-04-01 09:08:37 EDT 
(In reply to Andrey Loskutov from comment #6)
> I see this in Package Explorer too, in I20190331-1800
> 
> Steps:
> 
> 1) Package Explorer contains lot of projects.
> 2) Make sure tree has V scrollbar, so 50% of the content is hidden.
> 3) Scroll to the project in the middle.
> 4) Expand one of the children elements.
> 5) Tree scrolls to the top.
> 6) Scroll back and try to collapse/expand same element => no jumps.
> 7) Expand next element => tree scrolls to the top again.

I was able to reproduce the issue, only on X11. Will investigate.
Comment 8 Eric Williams CLA 2019-04-01 09:37:48 EDT 
The regression comes from the fix to bug 489751. Xi, please investigate.
Comment 9 Eclipse Genie CLA 2019-04-01 13:18:43 EDT 
New Gerrit change created: https://git.eclipse.org/r/139854
Comment 11 Eric Williams CLA 2019-04-01 15:57:05 EDT 
(In reply to Eclipse Genie from comment #10)
> Gerrit change https://git.eclipse.org/r/139854 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=5cd547013e057edf020e3f048738eda50818fdb3

In master now, thanks for the fix Xi.
Comment 12 Andrey Loskutov CLA 2019-04-02 03:50:38 EDT 
Verified with I20190401-1800. Thanks.