Community
Participate
Working Groups
When closing a composite part (For example a split editor) the inner parts will not removed. Upon profiling, I found that one of the places where the Inner parts remain are in the PartActivationHistory which does not take into account removing inner composite parts. Since these parts are not removed, their transient data is also not cleared, for example in the case of a split editor, the EditorReference will not be removed. In the case of custom editors, it means the transient data will now effectively live for the entire session.
I guess this is not a regression in 4.11. Could you please provide a Gerrit patch and/or attach small project to reproduce?
Created attachment 278037 [details] Project showing various cases where the MPart does not get disposed I created a project with the intention to demonstrate the specific PartActivationHistory leak, however it looks to me like every View is currently not being correctly disposed. The project now shows all the cases I found : - Workbench page does not correctly dispose an E4 view reference - Compatibility view parts don't get disposed (Even with the RemoveOnHide tag) - Part activation History does not forget inner parts. The 3 cases are available as menu entries in the LeakDemo menu, the second case (Compatiblity view) is commented out in favour of a variation that does not leak (Editor) to show that other similar cases actually get disposed correctly. I can probably submit a fix for the PartActivationHistory issue this week, but I'm not sure I have the time to address the rest of the issues, or if it actually is valid to not dispose the part in some cases.
This issue goes back to at least Oxygen.3 (That was my target platform initially but I tested this also on 2019.3 and the issues are still there)
(In reply to Ghaith Hachem from comment #2) > I can probably submit a fix for the PartActivationHistory issue this week, > but I'm not sure I have the time to address the rest of the issues, or if it > actually is valid to not dispose the part in some cases. Sorry for late follow up, could you just push the fix your mention on Gerrit, and we can discuss if it is worth or not to merge it?
