Comment 1 Amit Mendapara 2019-03-12 03:10:38 EDT

Created attachment 277829 [details]
light-toolbar.gif

See here with light theme, toolbar background is perfectly adjusted with parent widget background.

Comment 2 Amit Mendapara 2019-03-12 03:11:44 EDT

Created attachment 277830 [details]
dark-toolbar.gif

While with dark theme, toolbar background is fixed and doesn't look good.

Comment 3 Amit Mendapara 2019-03-12 03:12:54 EDT

Created attachment 277831 [details]
combo-items.gif

Also with combobox widget, the selection item background doesn't match the popup background.

Comment 4 Eric Williams 2019-03-12 09:36:45 EDT

Thanks for the bug report, we'll investigate for 4.12.

Comment 5 Eric Williams 2019-03-12 11:29:24 EDT

Seems to go back all the way to 4.8 -- I didn't go back any further.

Comment 6 Amit Mendapara 2019-03-13 04:44:38 EDT

IMO, instead of using hard coded colors, The dark theme should use system color palette. It seems that the light theme is perfectly adjusting colors as per gtk3 Adwaita light theme.

Comment 7 Eric Williams 2019-03-14 10:20:19 EDT

(In reply to Amit from comment #6)
> IMO, instead of using hard coded colors, The dark theme should use system
> color palette. It seems that the light theme is perfectly adjusting colors
> as per gtk3 Adwaita light theme.

This is already the case actually. It appears this bug is most likely caused by something else.

Comment 8 Amit Mendapara 2019-03-15 03:30:38 EDT

I see.

BTW, I tried to check using e4 tools. The css inspector is showing hard coded color. If I change the color from inspector, it's reverting to original color if I resize the explorer. However, if I use scratchpad than it's working but still it's fixed. I even tried like this:

CTabFolder ToolBar {
  background-color: #262626;
}

CTabFolder:focus ToolBar {
  background-color: #292929;
}

but no effect. So yes, issue seems to be somewhere else.

Comment 9 Eric Williams 2019-05-08 09:28:50 EDT

Unfortunately we have run out of time for 4.12, will investigate for 2019-09.

Comment 10 Amit Mendapara 2019-06-20 11:38:37 EDT

Created attachment 279026 [details]
eclipse-4.12.gif

Just checked 2019-06 release. Seems toolbar issue is partially solved. However, when we resize the window or sidebars we can still see the issue.

Also the hover on inactive tab shows unnecessary white border.

Comment 11 Amit Mendapara 2019-06-20 11:45:23 EDT

However, with Adwaita-dark theme we still have same old issues.

Comment 12 Amit Mendapara 2019-10-13 01:07:31 EDT

Looks like related to #539661. I just tested by uncommenting:

CTabFolder > #ToolbarComposite,
CTabFolder > #ToolbarComposite > *,
CTabFolder > #ToolbarComposite > Toolbar > *
{
	background-color:inherit;
}

in e4-dark_globalstyles.css seems fixing the toolbar within CTabFolder issue.

Still few issues like unselected tab border color on mouse hover, selection options background color are there.

Comment 13 Amit Mendapara 2019-10-13 01:16:14 EDT

IMO, hard coded colors in dark theme css files are not good option. Instead, there should be some ColorDefinition defined so that we can provide consistent colors per platform.

Comment 14 Eric Williams 2019-10-31 10:06:06 EDT

(In reply to Amit from comment #13)
> IMO, hard coded colors in dark theme css files are not good option. Instead,
> there should be some ColorDefinition defined so that we can provide
> consistent colors per platform.

I agree, and on Linux the native dark theme support is pretty good -- we shouldn't be manually styling widgets like ToolBars.

Lars this looks like a good candidate for a Platform UI fix, what do you think?

Comment 15 Lars Vogel 2020-05-18 07:54:48 EDT

Thanks Amit. Multiple dark theme issues have been fixed with the 2020-06 release. Please check with latest I-Build from https://download.eclipse.org/eclipse/downloads/ and report new bug report per issue. Having one bug for multiple issues is always hard to work on. I mark this one as worksforme, as parts of it are fixed, others not.

Comment 16 Amit Mendapara 2020-05-18 08:56:50 EDT

Thanks Lars for the good work.

I just tried the latest I-Build (I20200515-1930) and indeed many of the issues seems fixed. The combo box selection items are still not styled properly. See the combo-items.gif attachment.

Comment 17 Lars Vogel 2020-05-18 09:04:16 EDT

(In reply to Amit from comment #16)
> Thanks Lars for the good work.
Lots of people worked on the dark theme
> I just tried the latest I-Build (I20200515-1930) and indeed many of the
> issues seems fixed. The combo box selection items are still not styled
> properly. See the combo-items.gif attachment.

Please open a new bug for that

Comment 18 Amit Mendapara 2020-05-18 09:23:37 EDT

Done. See #563290