Community
Participate
Working Groups
Currently, the "allPopups" value in menuContribution extentions is ignored. By default, this value should have been "false", however the current behavior is "true" for all cases. Probably it is a bad idea, to start using the "false" default again, so best it is to switch to a "true" default, or remove this value at all. MenuPopulationTest.testPrivatePopup test the usage of the "allPopups" value, this test currently fails. Note that the test assumes "true" as default value. From the extension definition: By default popup contributions are not contributed to context menus that do not include an "additions" marker.
I suggest to remove it, or do you see an issue with that Rolf?
(In reply to Lars Vogel from comment #1) > I suggest to remove it, or do you see an issue with that Rolf? Effectively it is not used, for a long time now, and apparently nobody is complaining. So I don't see any problem in removing it. Though it could result in cluttering popup menus that should not have been extended, or are extended at unpredictable locations. Then again, it might be that the current framework always inserts an "additions" markers in menus (at least in some cases it does if I remember correctly). Just wondering now what the behavior would be for: <menuContribution locationURI="popup:org.eclipse.ui.popup.any?after=additions"> Without having a "additions" marker in a menu.
For 4.11 this is too late/risky.
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
