544502 – Missing Builder classes for SWT Table and TableColumn

Bug 544502 - Missing Builder classes for SWT Table and TableColumn

Summary: Missing Builder classes for SWT Table and TableColumn

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.11
Hardware:	PC Mac OS X

Importance:	P3 normal (vote)
Target Milestone:	4.11 RC1
Assignee:	Marcus Höpfner
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	553700
	Show dependency tree

Reported:	2019-02-15 11:26 EST by Marcus Höpfner
Modified:	2019-12-03 09:11 EST (History)
CC List:	3 users (show)

See Also:	Gerrit Change Gerrit Change Gerrit Change Git Commit Git Commit Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Marcus Höpfner

2019-02-15 11:26:59 EST

related to https://bugs.eclipse.org/bugs/show_bug.cgi?id=539014.
Add the same for Table please.

Comment 1 Marcus Höpfner

2019-02-15 11:27:36 EST

FYI: I'am currently working on that.

Comment 2 Eclipse Genie

2019-02-15 12:06:13 EST

New Gerrit change created: https://git.eclipse.org/r/137033

Comment 3 Eclipse Genie

2019-02-15 12:06:24 EST

New Gerrit change created: https://git.eclipse.org/r/137032

Comment 4 Matthias Becker

2019-02-21 08:38:47 EST

I gave my 1+ for:

https://git.eclipse.org/r/137032
https://git.eclipse.org/r/137033
https://git.eclipse.org/r/137017

Can they be merged for RC1?
Until we merge the gerrit in https://bugs.eclipse.org/bugs/show_bug.cgi?id=544489
the code is not used in platform. So I think the risk of merging them is minimal.

What do you think?

Comment 5 Dani Megert

2019-02-21 09:06:04 EST

(In reply to Matthias Becker from comment #4)
> I gave my 1+ for:
> 
> https://git.eclipse.org/r/137032
> https://git.eclipse.org/r/137033
> https://git.eclipse.org/r/137017
> 
> Can they be merged for RC1?
Definitely not before master is open again after declaring M3.

Comment 6 Matthias Becker

2019-02-22 03:54:32 EST

(In reply to Dani Megert from comment #5)
> (In reply to Matthias Becker from comment #4)
> > I gave my 1+ for:
> > 
> > https://git.eclipse.org/r/137032
> > https://git.eclipse.org/r/137033
> > https://git.eclipse.org/r/137017
> > 
> > Can they be merged for RC1?
> Definitely not before master is open again after declaring M3.

So master ist open for RC1. Can I merge these changes now?

Comment 7 Lars Vogel

2019-02-22 03:58:28 EST

(In reply to Matthias Becker from comment #6)

> So master ist open for RC1. Can I merge these changes now?

IMHO +1, as they are not yet API.

Comment 8 Eclipse Genie

2019-02-22 04:10:03 EST

Gerrit change https://git.eclipse.org/r/137017 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0a6a909a8de2593e7b6eb18080f1062677512070

Comment 9 Eclipse Genie

2019-02-22 04:35:26 EST

Gerrit change https://git.eclipse.org/r/137032 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=8917477118d5be03c48ad67a7a04654af7e0c0b1

Comment 10 Eclipse Genie

2019-02-22 04:35:40 EST

Gerrit change https://git.eclipse.org/r/137033 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c9556698bdbbc0e4a0af88a33ea126fcfc4335ea

Comment 11 Matthias Becker

2019-02-22 04:36:28 EST

Thank you marcus for your help.