Bug 544360 - [Mac] Show alternating lines for Tree and Table in Dark theme when set
Summary: [Mac] Show alternating lines for Tree and Table in Dark theme when set
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.10   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 4.12 M3   Edit
Assignee: Till Brychcy CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2019-02-12 00:54 EST by Lakshmi P Shanmugam CLA
Modified: 2019-05-22 08:06 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lakshmi P Shanmugam CLA 2019-02-12 00:54:19 EST 
From Bug544039#c24

It'll be nice to have the alternating lines for Table and Tree shown in the Dark theme. Currently they have the background color set and hence the lines are not visible. Using unset in the css for Table/Tree background color works, but it should be done only when line visibility is set.
Comment 1 Eclipse Genie CLA 2019-05-03 04:10:24 EDT 
New Gerrit change created: https://git.eclipse.org/r/141561
Comment 2 Till Brychcy CLA 2019-05-09 14:34:41 EDT 
I'm not convinced by the black background in the dark design if line visibility is of, so in change set 3, I've added a css attribute swt-lines-visible and use it to unset the background only if line visibility is true.

WDYT?
Comment 3 Lakshmi P Shanmugam CLA 2019-05-10 05:52:50 EDT 
(In reply to Till Brychcy from comment #2)
> I'm not convinced by the black background in the dark design if line
> visibility is of, so in change set 3, I've added a css attribute
> swt-lines-visible and use it to unset the background only if line visibility
> is true.
> 
> WDYT?

@Till, Looks nice!
The black background is the Table/Tree's default background color in dark mode, may be it looked a little odd with gray background in rest of Eclipse UI. With your patch, the Package Explorer and Outline View's background match with rest of Eclipse.
Comment 5 Lakshmi P Shanmugam CLA 2019-05-11 07:46:02 EDT 
Thanks for fixing this!
Comment 6 Lars Vogel CLA 2019-05-11 09:19:25 EDT 
Please add to N&N
Comment 7 Eclipse Genie CLA 2019-05-22 07:38:55 EDT 
New Gerrit change created: https://git.eclipse.org/r/142580
Comment 9 Eclipse Genie CLA 2019-05-22 08:05:21 EDT 
New Gerrit change created: https://git.eclipse.org/r/142584