Bug 544222 - Opening a view in the PDE perspective uses wrong stack
Summary: Opening a view in the PDE perspective uses wrong stack
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.10   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: usability
: 511459 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-02-07 08:17 EST by Lars Vogel CLA
Modified: 2020-11-30 05:45 EST (History)
4 users (show)

See Also:


Attachments
Screencast demonstrating the issue (1.93 MB, image/gif)
2019-02-07 08:17 EST, Lars Vogel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2019-02-07 08:17:13 EST
Created attachment 277491 [details]
Screencast demonstrating the issue

If I open a new view in the PDE perspective the existing bottom stack is not used. In Java it uses the bottom stack which is IMHO the desired behaviour.

See screencast.
Comment 1 Rolf Theunissen CLA 2019-05-26 07:38:19 EDT
Observations:
1. In case of the console: The console location is predefined in the Java Perspective, but hidden by default. The PDE Perspective does not have a hidden console.
2. When GIT is installed, the last PartStack in the PDE Perspective is a not-rendered PartStack. 


When opening a view the following cases are considered to find the stack to open the view in:
1. In case there is a hidden placeholder/part, make it visible in that location.
2. In case there is a PartStack with a tag that matches the category tag of placeholder/part, add the placeholder/part to that PartStack.
3. In case multiple instances of the views are allowed, and another instance of the view is already open, add the placeholder/part to the same PartStack as the other view.
4. Otherwise, add the placeholder/part to the last PartStack.

After a placeholder/part is added to a PartStack, its category tag is applied to the PartStack (if the category tag was not found).


Problems:
1. Category tags are not applied for views that are defined in the Perspective. Only for explicitly opened views categories tags are added. Therefore, newly opened views are not kept with already open views of the same category.
2. Category tags are not updated when views are moved. Not sure though what behavior would be required here.
3. Finding the last PartStack results in unexpected candidates:
   a. It considers not-rendered PartStacks.
   b. In case the Welcome-Screen is open, the PartStack of the Welcome-Screen is the last PartStack. The view will be opened in the 'sticky' PartStack, see also Bug 511459.
Comment 2 Rolf Theunissen CLA 2019-05-26 08:56:08 EDT
*** Bug 511459 has been marked as a duplicate of this bug. ***