Bug 544088 - Method closeAllPerspective of class WorkbenchPage always call closePerspective with false value for parameter saveParts
Summary: Method closeAllPerspective of class WorkbenchPage always call closePerspectiv...
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.6   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: needinfo
Depends on:
Blocks:
 
Reported: 2019-02-04 05:33 EST by Thibaud Michaudel CLA
Modified: 2021-02-07 02:09 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thibaud Michaudel CLA 2019-02-04 05:33:17 EST
Issue detected in eclipse 4.6 but still present in head of master branch.

Branch : Master
Commit : 0d9138c769945c3073db163fd43ee92168e4d5bd

In org.eclipse.ui.internal.WorbenchPage the method closeAllPerspectives(boolean saveEditors, boolean closePage) is not using the value of the boolean saveEditors when calling closePerspective(IPerspectiveDescriptor desc, String perspectiveId, boolean saveParts).

Instead, the method closePerspective is called with false as value for the parameter saveParts. As a result, when closing a perspective on eclipse RCP with a view containing unsaved changes, the user is never prompted to save the view.

Hacking the eclipse jar org.eclipse.ui.workbench_3.108.3.v20170216-1539 to behave as described above, it works the expected way (the user is prompted to save dirty views when closing a perspective).
Comment 1 Dani Megert CLA 2019-02-09 11:52:43 EST
Please provide a test case or sample project.
Comment 2 Andrey Loskutov CLA 2019-02-17 17:21:42 EST
Please provide a Gerrit patch, ideally with a test case.
See https://wiki.eclipse.org/Platform_UI/How_to_Contribute
Comment 3 Eclipse Genie CLA 2021-02-07 02:09:14 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.