543984 – [GTK4] Adapt to GdkEventType constants changes

Bug 543984 - [GTK4] Adapt to GdkEventType constants changes

Summary: [GTK4] Adapt to GdkEventType constants changes

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	SWT (show other bugs)
Version:	4.10
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.11 M3
Assignee:	Xi Yan
QA Contact:

URL:
Whiteboard:
Keywords:	triaged

Depends on:
Blocks:	540385
	Show dependency tree

Reported:	2019-01-30 11:29 EST by Xi Yan
Modified:	2019-02-19 09:56 EST (History)
CC List:	1 user (show)

See Also:	Gerrit Change Git Commit Gerrit Change Gerrit Change Git Commit Git Commit Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Xi Yan

2019-01-30 11:29:51 EST

some GdkEventType constants are removed (i.e. GDK_2BUTTON_PRESS) or changed values on GTK4, which messes up the events sent by SWT.

Comment 1 Eric Williams

2019-01-30 11:34:13 EST

Yup I ran into this the other day as well.

Comment 2 Xi Yan

2019-01-30 11:50:40 EST

constants that have changed:

GDK_EXPOSE 3
GDK_BUTTON_PRESS 5
GDK_BUTTON_RELEASE 6
GDK_KEY_PRESS 7
GDK_KEY_RELEASE 8
GDK_FOCUS_CHANGE 11
GDK_MAP 13
GDK_UNMAP 14

constants that have been removed:

GDK_2BUTTON_PRESS
GDK_3BUTTON_PRESS

Comment 3 Eclipse Genie

2019-01-31 12:21:17 EST

New Gerrit change created: https://git.eclipse.org/r/136100

Comment 4 Eclipse Genie

2019-01-31 14:37:24 EST

Gerrit change https://git.eclipse.org/r/136100 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=2f5a98b4cbd50b436a5ffad0a1d5949f3b9a1b18

Comment 5 Eclipse Genie

2019-01-31 15:06:52 EST

New Gerrit change created: https://git.eclipse.org/r/136105

Comment 6 Eclipse Genie

2019-01-31 15:18:07 EST

New Gerrit change created: https://git.eclipse.org/r/136106

Comment 7 Eclipse Genie

2019-01-31 15:18:50 EST

Gerrit change https://git.eclipse.org/r/136106 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=ecf521c3d6bf4f8734858eb1d2b7d39de0a0ad17

Comment 8 Eclipse Genie

2019-02-04 15:07:44 EST

Gerrit change https://git.eclipse.org/r/136105 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=a43e2d35df296d43c4e345e18c2412744183d278

Comment 9 Eric Williams

2019-02-04 15:17:32 EST

In master now, thanks Xi.

Comment 10 Eclipse Genie

2019-02-13 10:50:28 EST

Gerrit change https://git.eclipse.org/r/136580 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=7c2bb7000bca9e2c79a80b9d0a2fc149f3d2e6de

Comment 11 Xi Yan

2019-02-19 09:56:51 EST

Verified in I20190219-0600.