Bug 543850 - Update artifactcomparator asm dep to 7.0
Summary: Update artifactcomparator asm dep to 7.0
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Tycho (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Alexander Kurtakov CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2019-01-25 14:14 EST by Alexander Kurtakov CLA
Modified: 2021-04-28 16:52 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kurtakov CLA 2019-01-25 14:14:35 EST 
ASM 7.0 is needed so artifactcomparator can understand Java10+ bytecode. See https://asm.ow2.io/versions.html for details.
Comment 1 Alexander Kurtakov CLA 2019-01-25 14:16:33 EST 
Tycho uses asm-debug-all.jar now but it is no longer part of ASM 6.0+ so the split jars have to be used aka:
org.ow2.asm:asm-tree:jar:7.0
org.ow2.asm:asm:jar:7.0
org.ow2.asm:asm-util:jar:7.0
org.ow2.asm:asm-analysis:jar:7.0

CQs to be filed shortly.
Comment 2 Alexander Kurtakov CLA 2019-01-25 14:23:44 EST 
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=18833 - single CQ as all asm 7.0 jars needed are approved as single CQ.
Comment 3 Eclipse Genie CLA 2019-01-25 14:34:04 EST 
New Gerrit change created: https://git.eclipse.org/r/135790
Comment 4 Alexander Kurtakov CLA 2019-01-25 15:00:18 EST 
(In reply to Alexander Kurtakov from comment #2)
> https://dev.eclipse.org/ipzilla/show_bug.cgi?id=18833 - single CQ as all asm
> 7.0 jars needed are approved as single CQ.

CQ is approved.
Comment 6 Mickael Istria CLA 2019-03-05 04:15:26 EST 
@Alex, would you mind adding a note about it to https://wiki.eclipse.org/Tycho/Release_Notes/1.4 ?
Comment 7 Alexander Kurtakov CLA 2019-03-05 05:43:54 EST 
(In reply to Mickael Istria from comment #6)
> @Alex, would you mind adding a note about it to
> https://wiki.eclipse.org/Tycho/Release_Notes/1.4 ?

Done.