Bug 543501 - Open Resource dialog filter pattern should accept a single star
Summary: Open Resource dialog filter pattern should accept a single star
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-16 10:23 EST by Sebastian Baumann CLA
Modified: 2019-01-30 04:34 EST (History)
3 users (show)

See Also:


Attachments
Resetting the pattern if the user types * (302 bytes, text/plain)
2019-01-16 10:23 EST, Sebastian Baumann CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Baumann CLA 2019-01-16 10:23:25 EST
Created attachment 277175 [details]
Resetting the pattern if the user types *

The Open Resource dialog (org.eclipse.ui.dialogs.FilteredItemsSelectionDialog) should show all matches if input is a single star "*". Typing two stars "**" to reveal all elements makes no sense at all.

In the internal class ItemsFilter, the search pattern will be set to "" if the user types "*":
Comment 1 Lars Vogel CLA 2019-01-16 10:28:50 EST
Please create a Gerrit
Comment 2 Dani Megert CLA 2019-01-16 11:03:17 EST
-1 for such a change.

Showing all matches in both, Open Resource and Open Type is expensive. In the most cases users want to use * to enter a pattern and not to show everything.

However, we should at least document the usage of "**". Maybe even show it in the dialog.
Comment 3 Sebastian Baumann CLA 2019-01-29 06:43:12 EST
I understand. But can we check whether this perfomance issue is still up to date? We have about 25000 resources showing up almost immediatelly with ** as well as 96000 items with Open Type. It's just a kind of inconsistency in * behavior and description e. g. in software install dialog AvailableIUsPage.
Comment 4 Dani Megert CLA 2019-01-29 12:06:28 EST
(In reply to Sebastian Baumann from comment #3)
> I understand. But can we check whether this perfomance issue is still up to
> date? We have about 25000 resources showing up almost immediatelly with **
> as well as 96000 items with Open Type. It's just a kind of inconsistency in
> * behavior and description e. g. in software install dialog AvailableIUsPage.
Yeah, that looks like you're having a baby workspace ;-).

In my workspace (400 projects) both dialogs don't have the results below minutes.

I can't tell you how many resources or types are there because when I select all items, I run into bug 353540 which blocks my workspace entirely, and I have to kill it.
Comment 5 Sebastian Baumann CLA 2019-01-30 04:22:46 EST
Ah ok I see :-) In that case, I agree.
Remains only the missing documentation of the ** usage.