Bug 543360 - "Finding differences" message should be on editor and not be a popup
Summary: "Finding differences" message should be on editor and not be a popup
Status: REOPENED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 4.8   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform Team Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted, usability
Depends on:
Blocks: 577364
  Show dependency tree
 
Reported: 2019-01-11 04:13 EST by Mickael Istria CLA
Modified: 2021-11-25 09:06 EST (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mickael Istria CLA 2019-01-11 04:13:03 EST 
When switching between branches or replacing a file while a compare editor is open (but not being currently visible), I see a "Finding differences" pop-up annoying me while I'm actually looking at a different editor.
The feedback that the compare editor is refreshing should be in the editor, and not a global popup.
Comment 1 Lars Vogel CLA 2019-06-18 02:56:20 EDT 
+1
Comment 2 Lars Vogel CLA 2019-06-18 02:57:30 EDT 
Or we can simply remove the dialog completely, editors are responsible for loading.

Anyone interested in fixing this bug?
Comment 3 Lars Vogel CLA 2019-06-18 04:11:02 EDT 
Location of the String

eclipse.platform.team/bundles/org.eclipse.compare.core/src/org/eclipse/compare/internal/core/messages.properties:RangeComparatorLCS_0=Finding differences
Comment 4 Lars Vogel CLA 2019-06-18 04:24:03 EDT 
(In reply to Lars Vogel from comment #3)
> Location of the String
> 
> eclipse.platform.team/bundles/org.eclipse.compare.core/src/org/eclipse/
> compare/internal/core/messages.properties:RangeComparatorLCS_0=Finding
> differences

Sorry, I think the correct file is /org.eclipse.compare/compare/org/eclipse/compare/internal/CompareMessages.properties
Comment 5 Eclipse Genie CLA 2021-06-08 08:10:47 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 6 Mickael Istria CLA 2021-06-08 08:11:46 EDT 
Still relevant
Comment 7 Lars Vogel CLA 2021-06-08 08:13:52 EDT 
(In reply to Mickael Istria from comment #6)
> Still relevant

Do we need it at all? If yes, I suggest we should use a non-blocking notification.
Comment 8 Mickael Istria CLA 2021-06-08 08:16:59 EDT 
(In reply to Lars Vogel from comment #7)
> Do we need it at all? If yes, I suggest we should use a non-blocking
> notification.

I think so, This can be a long running operation, so if user goes to another editor then back on the compare editor, they need to be able to determine whether work is in progress or whether it's complete.
Comment 9 Niraj Modi CLA 2021-11-25 08:59:47 EST 
Moving out of 4.22
Comment 10 Mickael Istria CLA 2021-11-25 09:06:15 EST 
(In reply to Niraj Modi from comment #9)
> Moving out of 4.22

Or even later ;)