Bug 542974 - [Dark Theme] Message of Text.setMessage is unreadable
Summary: [Dark Theme] Message of Text.setMessage is unreadable
Status: REOPENED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.9   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-21 03:39 EST by Wim Jongman CLA
Modified: 2020-12-03 15:53 EST (History)
1 user (show)

See Also:

Attachments
Dark (616 bytes, image/png)
2018-12-21 03:47 EST, Wim Jongman CLA 		no flags Details
Light (577 bytes, image/png)
2018-12-21 03:47 EST, Wim Jongman CLA 		no flags Details
Screenshot (7.72 KB, image/png)
2018-12-21 04:10 EST, Lars Vogel CLA 		no flags Details
Ok in quick access not ok in new wizard wizard (35.39 KB, image/png)
2018-12-21 05:19 EST, Wim Jongman CLA 		no flags Details
Light theme (46.61 KB, video/mp4)
2020-12-03 15:53 EST, Wim Jongman CLA 		no flags Details
Dark Theme (24.19 KB, video/mp4)
2020-12-03 15:53 EST, Wim Jongman CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wim Jongman CLA 2018-12-21 03:39:37 EST 
We are able to set a content hint with Text.setMessage. This is unreadable in the Dark Theme.
Comment 1 Wim Jongman CLA 2018-12-21 03:47:08 EST 
Created attachment 276976 [details]
Dark
Comment 2 Wim Jongman CLA 2018-12-21 03:47:42 EST 
Created attachment 276977 [details]
Light
Comment 3 Lars Vogel CLA 2018-12-21 04:10:21 EST 
Created attachment 276978 [details]
Screenshot

Looks OK for me on Linux. Which dialog are you using as example? We may want to tweek the background color for Text fields on Windows. 

Can you have a look:

org.eclipse.ui.themes File: e4-dark_win.css
Comment 4 Wim Jongman CLA 2018-12-21 05:19:09 EST 
Created attachment 276979 [details]
Ok in quick access not ok in new wizard wizard
Comment 5 Wim Jongman CLA 2018-12-21 05:20:00 EST 
(In reply to Lars Vogel from comment #3)
> Created attachment 276978 [details]
> Screenshot
> 
> Looks OK for me on Linux. 


I think that is not very readable
Comment 6 Lars Vogel CLA 2018-12-21 05:37:37 EST 
(In reply to Wim Jongman from comment #5)
> (In reply to Lars Vogel from comment #3)
> > Created attachment 276978 [details]
> > Screenshot
> > 
> > Looks OK for me on Linux. 
> 
> 
> I think that is not very readable

:-) I'm very much open for improvements.
Comment 7 Wim Jongman CLA 2018-12-21 07:22:31 EST 
(In reply to Lars Vogel from comment #6)
> (In reply to Wim Jongman from comment #5)
> > (In reply to Lars Vogel from comment #3)
> > > Created attachment 276978 [details]
> > > Screenshot
> > > 
> > > Looks OK for me on Linux. 
> > 
> > 
> > I think that is not very readable
> 
> :-) I'm very much open for improvements.

Me too! ;)
Comment 8 Lars Vogel CLA 2020-05-22 10:40:15 EDT 
Looks better in Eclipse SDK
Version: 2020-06 (4.16)
Build id: I20200521-1000
OS: Windows 10, v.10.0, x86_64 / win32
Java version: 11.0.7
Comment 9 Wim Jongman CLA 2020-12-03 15:52:21 EST 
This has not been solved or it has regressed since 2020-06. I'm running Windows Dark theme and setMessage is not readable at all in the dark theme.
Comment 10 Wim Jongman CLA 2020-12-03 15:53:00 EST 
Created attachment 284957 [details]
Light theme
Comment 11 Wim Jongman CLA 2020-12-03 15:53:30 EST 
Created attachment 284958 [details]
Dark Theme