Bug 542754 - Update GitHub branch protection settings for eclipse-ee4j/jaxrs-api
Summary: Update GitHub branch protection settings for eclipse-ee4j/jaxrs-api
Status: CLOSED FIXED
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: GitHub (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Eclipse Webmaster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-13 07:20 EST by Christian Kaltepoth CLA
Modified: 2018-12-13 09:51 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Kaltepoth CLA 2018-12-13 07:20:34 EST 
We are having a lot of problems with the 'ip-validation' check which is enabled for the GitHub repository. See #540694 for a detailed description.

AFAIK the eclipse-ee4j/jaxrs-api repository has a branch protection configured for the "master" and "EE4J" branches which requires a successful 'ip-validation' check to be able to merge pull request. 

Could you please disable this requirement so that we can merge pull requests even if the 'ip-validation' doesn't report the status correctly? Unfortunately this is currently a complete blocker for us.

Thanks a lot!
Comment 1 Frederic Gurr CLA 2018-12-13 08:46:17 EST 
@Wayne: Can you comment on that?
Comment 2 Christian Kaltepoth CLA 2018-12-13 09:22:20 EST 
IIRC we explicitly requested to enable the 'Require status checks to pass before merging' option for the 'ip-validation' check. Please see your comment here:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=534177#c1

Or is this option in the branch protections settings enforced for all Eclipse projects and branches?
Comment 3 Frederic Gurr CLA 2018-12-13 09:41:44 EST 
You're right, we don't enforce branch protection (yet). I've disabled the required ip validation status check.
Comment 4 Christian Kaltepoth CLA 2018-12-13 09:51:27 EST 
Awesome! Thank you very much!