Community
Participate
Working Groups
Hi all, the EE4J JAX-RS project recently agreed on the following GitHub branch protection configuration for the "master" branch: https://dev.eclipse.org/mhonarc/lists/jaxrs-dev/pngMmrGEsqLje.png You can find the corresponding vote here: https://dev.eclipse.org/mhonarc/lists/jaxrs-dev/msg00363.html It would be great if you could configure the branch protection settings for the master branch es shown in the screenshot. Thanks a lot for your help. Let me know if you need any further information. Christian
Master branch protection has been enabled. I was able to select the Eclipse IP check, but not the "continuous-integration/travis-ci" as a required status check that needs to pass before merging.
Thanks a lot for your help! It is really weird that you cannot activate Travis as a required status check. I just double-checked that. I tried to enabled protected branches for some other repository for which I have admin permissions and for which Travis is enabled (actually the same repository from which I created the screenshot). For some reason Travis isn't listed there anymore too. I'll try to find out what is causing this and come back to you ASAP. Thanks Christian
Hi, sorry, but it looks like I made a mistake in the screenshot. I checked "Require signed commits", because I thought that this option refers to the "Signed-off-by" field in the commit message. But it looks like actually this setting requires all commits to get GPG signed. Could you please disable the "Require signed commits" option? I'm very sorry for the confusion. Christian
Done. Updated permissions may take a few minutes to take effect.
Awesome! Thanks a lot! I was able to merge the pull request now. One last thing. Frederic wrote that he wasn't able to enable the "continuous-integration/travis-ci" check for the master branch. I guess that's because the GitHub settings only list integrations which were executed in the last week and we had no commits on the master branch for a few days. As we just merged a pull requests, this has triggered a Travis build for the master branch. So I guess the "continuous-integration/travis-ci" check should now appear in the settings. If so, could you please mark it as a "required check" as shown in the screenshot? Thank you very much for your support.
Created attachment 273914 [details] ee4j/jaxrs-api master branch settings (In reply to Christian Kaltepoth from comment #5) > As we just merged a pull requests, this has triggered a Travis build for the > master branch. So I guess the "continuous-integration/travis-ci" check > should now appear in the settings. If so, could you please mark it as a > "required check" as shown in the screenshot? Done (cf screenshot). Again updated settings may take a few minutes to take effect. > Thank you very much for your support. You're very welcome.
closing.
