Community
Participate
Working Groups
I noticed that I ALWAYS maximize the smart import dialog before starting to use it. If others, like Mickael the creator of this wizard, are doing the same, we should always open the wizard in maximized mode. Alternatively, we should remember the size and position of the wizard.
Mickael. WDYT?
(In reply to Lars Vogel from comment #0) > we should always open the wizard in maximized mode. I would not like this, I've never needed maximized state here. Probably resolution/monitor dependent, but I had always enough space, on both my Linux workstation/Windows notebook. > Alternatively, we should remember the size and position of the wizard. This would be fine, but shouldn't this be already there? If not: why? Is this per-wizard?
> If others, like Mickael the creator of this wizard, are doing the same, we should always open the wizard in maximized mode. I don't think I do that always. I maybe did it once or twice in my life and you were lucky to be there ;) I'm not sure we should make this wizard behave differently of other ones in general.
Also -1 to open maximized. Remembering the size would be OK for me.
(In reply to Andrey Loskutov from comment #2) > This would be fine, but shouldn't this be already there? It does not remember its size for me. Does it for you?
(In reply to Lars Vogel from comment #5) > (In reply to Andrey Loskutov from comment #2) > > > This would be fine, but shouldn't this be already there? > > It does not remember its size for me. Does it for you? No, I was just surprised (again) that wizards have to do extra work to remember size/location. Sounds like a missing default feature for me. As a wizard user I most likely want the wizard to remember settings / size. But I guess this expectation applies to all JFace dialogs (not just wizards), which makes me wonder what was rationale not to do this by default.
Julian, you fixed various dialogs not remembering their size. Can you take this one too?
Wizards can't remember any size/bounds - only the WizardDialog could do that. WizardDialog could implement getDialogBoundsSettings() and return the Wizard's dialog settings (if available). That would a) affect every Wizard, without any option to opt-out b) possibly break Wizards, because we stored unexpected contents in their settings Do we want that?
(In reply to Julian Honnen from comment #8) > Wizards can't remember any size/bounds - only the WizardDialog could do that. > > WizardDialog could implement getDialogBoundsSettings() and return the > Wizard's dialog settings (if available). That would > a) affect every Wizard, without any option to opt-out > b) possibly break Wizards, because we stored unexpected contents in > their settings > > Do we want that? Could we add API to opt-in?
(In reply to Julian Honnen from comment #8) > Wizards can't remember any size/bounds - only the WizardDialog could do that. > > WizardDialog could implement getDialogBoundsSettings() and return the > Wizard's dialog settings (if available). On second look, that doesn't work as a generic solution. A WizardDialog instance may be used for multiple Wizards. Like in the case of the import wizard, which dynamically adds pages from the selected import type.
