Description Nicola Orru 2018-12-09 15:41:24 EST

In Corrosion Rust/RLS client the "rename" functionality is not enabled in the IDE.

Quoting @mickaelistria: "It's a bug in LSP4E LSRenameHandler which doesn't use a good comparison to check capabilities. Please report a bug to LSP4E; there is "still a little timeframe to fix it for 2018-12.

Original report at:
https://github.com/eclipse/corrosion/issues/185#issuecomment-445543002

Here's the affected bit of the log:

```
nico@devuan-3xS:~/Projects/itadinanta/ofx-rs$ grep -i rename ~/Workspaces/workspace_rust/languageServers-log/org.eclipse.corrosion.rls.log 
LSP4E to org.eclipse.corrosion.rls:{"jsonrpc":"2.0","id":"1","method":"initialize","params":{"processId":4421,"rootPath":"/home/nico/Projects/itadinanta/ofx-rs/","rootUri":"file:///home/nico/Projects/itadinanta/ofx-rs/","initializationOptions":{"settings":{"rust":{"goto_def_racer_fallback":true,"clippy_preference":"on"}}},"capabilities":{"workspace":{"applyEdit":true,"workspaceEdit":{"documentChanges":true,"resourceOperations":["create","delete","rename"],"failureHandling":"undo"},"symbol":{},"executeCommand":{"dynamicRegistration":true},"workspaceFolders":true},"textDocument":{"synchronization":{"willSave":true,"willSaveWaitUntil":true,"didSave":true},"completion":{"completionItem":{"snippetSupport":true}},"hover":{},"signatureHelp":{},"references":{},"documentHighlight":{},"documentSymbol":{"symbolKind":{"valueSet":[18,17,5,14,9,10,22,24,8,1,12,11,20,6,2,3,21,16,19,25,4,7,15,23,26,13]},"hierarchicalDocumentSymbolSupport":true,"dynamicRegistration":true},"formatting":{},"rangeFormatting":{},"definition":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":["quickfix","refactor","refactor.extract","refactor.inline","refactor.rewrite","source","source.organizeImports"]}},"dynamicRegistration":true},"codeLens":{},"documentLink":{},"colorProvider":{},"rename":{}}},"clientName":"Eclipse IDE","trace":"off"}}
org.eclipse.corrosion.rls to LSP4E:{"jsonrpc":"2.0","id":1,"result":{"capabilities":{"textDocumentSync":2,"hoverProvider":true,"completionProvider":{"resolveProvider":true,"triggerCharacters":[".",":"]},"definitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"workspaceSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{"resolveProvider":false},"documentFormattingProvider":true,"documentRangeFormattingProvider":false,"renameProvider":true,"executeCommandProvider":{"commands":["rls.applySuggestion-4513","rls.deglobImports-4513"]}}}}
```

```
nico@devuan-3xS:~/Projects/itadinanta/ofx-rs$ grep -i refactor ~/Workspaces/workspace_rust/languageServers-log/org.eclipse.corrosion.rls.log 
LSP4E to org.eclipse.corrosion.rls:{"jsonrpc":"2.0","id":"1","method":"initialize","params":{"processId":4421,"rootPath":"/home/nico/Projects/itadinanta/ofx-rs/","rootUri":"file:///home/nico/Projects/itadinanta/ofx-rs/","initializationOptions":{"settings":{"rust":{"goto_def_racer_fallback":true,"clippy_preference":"on"}}},"capabilities":{"workspace":{"applyEdit":true,"workspaceEdit":{"documentChanges":true,"resourceOperations":["create","delete","rename"],"failureHandling":"undo"},"symbol":{},"executeCommand":{"dynamicRegistration":true},"workspaceFolders":true},"textDocument":{"synchronization":{"willSave":true,"willSaveWaitUntil":true,"didSave":true},"completion":{"completionItem":{"snippetSupport":true}},"hover":{},"signatureHelp":{},"references":{},"documentHighlight":{},"documentSymbol":{"symbolKind":{"valueSet":[18,17,5,14,9,10,22,24,8,1,12,11,20,6,2,3,21,16,19,25,4,7,15,23,26,13]},"hierarchicalDocumentSymbolSupport":true,"dynamicRegistration":true},"formatting":{},"rangeFormatting":{},"definition":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":["quickfix","refactor","refactor.extract","refactor.inline","refactor.rewrite","source","source.organizeImports"]}},"dynamicRegistration":true},"codeLens":{},"documentLink":{},"colorProvider":{},"rename":{}}},"clientName":"Eclipse IDE","trace":"off"}}
```